feat(backcompat): @types/node backcompat tests (#1352)

Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com>

Author: markwolff

.github/workflows/backcompat.yml

@@ -0,0 +1,33 @@
+name: Backwards Compatability
+
+on: [push, pull_request]
+
+jobs:
+ types-node:
+ runs-on: ubuntu-latest
+
+ steps:
+ - uses: actions/checkout@v2
+
+ - name: restore lerna
+ uses: actions/cache@master # must use unreleased master to cache multiple paths
+ id: cache
+ with:
+ path: |
+ node_modules
+ packages/*/node_modules
+ metapackages/*/node_modules
+ key: ${{ runner.os }}-${{ hashFiles('**/package.json') }}
+
+ - name: Bootstrap
+ if: steps.cache.outputs.cache-hit != 'true'
+ run: |
+ npm install --only=dev --ignore-scripts
+ npx lerna bootstrap --no-ci --ignore-scripts -- --only=dev
+
+ - name: Install and Build API Dependencies
+ run: npx lerna bootstrap --no-ci --scope backcompat-* --include-filtered-dependencies
+
+ - name:
+ run: |
+ npm run test:backcompat

backwards-compatability/node10/index.ts

@@ -0,0 +1,10 @@
+import {NodeSDK, api} from '@opentelemetry/sdk-node';
+import {ConsoleSpanExporter} from '@opentelemetry/tracing';
+
+const sdk = new NodeSDK({
+ traceExporter: new ConsoleSpanExporter(),
+ autoDetectResources: false,
+});
+sdk.start();
+
+api.trace.getTracer('test');

backwards-compatability/node10/package.json

@@ -0,0 +1,20 @@
+{
+ "name": "backcompat-node10",
+ "version": "1.0.0",
+ "private": true,
+ "description": "Backwards compatability app for node8 types and the OpenTelemetry Node.js SDK",
+ "main": "index.js",
+ "scripts": {
+ "test:backcompat": "tsc --noEmit index.ts"
+ },
+ "dependencies": {
+ "@opentelemetry/sdk-node": "^0.10.2",
+ "@opentelemetry/tracing": "^0.10.2"
+ },
+ "devDependencies": {
+ "@types/node": "^10.0.0",
+ "typescript": "^3.9.7"
+ },
+ "author": "OpenTelemetry Authors",
+ "license": "Apache-2.0"
+}

backwards-compatability/node12/index.ts

@@ -0,0 +1,10 @@
+import {NodeSDK, api} from '@opentelemetry/sdk-node';
+import {ConsoleSpanExporter} from '@opentelemetry/tracing';
+
+const sdk = new NodeSDK({
+ traceExporter: new ConsoleSpanExporter(),
+ autoDetectResources: false,
+});
+sdk.start();
+
+api.trace.getTracer('test');

backwards-compatability/node12/package.json

@@ -0,0 +1,20 @@
+{
+ "name": "backcompat-node12",
+ "version": "1.0.0",
+ "private": true,
+ "description": "Backwards compatability app for node8 types and the OpenTelemetry Node.js SDK",
+ "main": "index.js",
+ "scripts": {
+ "test:backcompat": "tsc --noEmit index.ts"
+ },
+ "dependencies": {
+ "@opentelemetry/sdk-node": "^0.10.2",
+ "@opentelemetry/tracing": "^0.10.2"
+ },
+ "devDependencies": {
+ "@types/node": "^12.0.0",
+ "typescript": "^3.9.7"
+ },
+ "author": "OpenTelemetry Authors",
+ "license": "Apache-2.0"
+}

backwards-compatability/node8/index.ts

@@ -0,0 +1,10 @@
+import {NodeSDK, api} from '@opentelemetry/sdk-node';
+import {ConsoleSpanExporter} from '@opentelemetry/tracing';
+
+const sdk = new NodeSDK({
+ traceExporter: new ConsoleSpanExporter(),
+ autoDetectResources: false,
+});
+sdk.start();
+
+api.trace.getTracer('test');

backwards-compatability/node8/package.json

@@ -0,0 +1,20 @@
+{
+ "name": "backcompat-node8",
+ "version": "1.0.0",
+ "private": true,
+ "description": "Backwards compatability app for node8 types and the OpenTelemetry Node.js SDK",
+ "main": "index.js",
+ "scripts": {
+ "test:backcompat": "tsc --noEmit index.ts"
+ },
+ "dependencies": {
+ "@opentelemetry/sdk-node": "^0.10.2",
+ "@opentelemetry/tracing": "^0.10.2"
+ },
+ "devDependencies": {
+ "@types/node": "^8.0.0",
+ "typescript": "^3.9.7"
+ },
+ "author": "OpenTelemetry Authors",
+ "license": "Apache-2.0"
+}

lerna.json

@@ -3,6 +3,7 @@
  "npmClient": "npm",
  "packages": [
  "benchmark/*",
+ "backwards-compatability/*",
  "metapackages/*",
  "packages/*",
  "integration-tests/*"

package.json

@@ -13,6 +13,7 @@
  "compile": "lerna run compile",
  "test": "lerna run test",
  "test:browser": "lerna run test:browser",
+ "test:backcompat": "lerna run test:backcompat",
  "bootstrap": "lerna bootstrap",
  "bump": "lerna publish",
  "codecov": "lerna run codecov",

packages/opentelemetry-core/src/platform/node/timer-util.ts

@@ -13,6 +13,6 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-export function unrefTimer(timer: NodeJS.Timeout): void {
+export function unrefTimer(timer: NodeJS.Timer): void {
  timer.unref();
 }