[maven-extension] Emit a warning rather than failing the build with an exception on illegal state #776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
maven-extension/src/main/java/io/opentelemetry/maven/SpanRegistry.java Outdated Show resolved Hide resolved
mateuszrzeszutek approved these changes Mar 13, 2023
kenfinnigan approved these changes Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description:
When an inconsistency is identified on the state of spans (eg caused by the forced interruption of a build or a bug in the extension), emit a warniong message in the logs rather than throwing an exception that breaks the Maven build.
Existing Issue(s):
Testing:
No testing of this defensive code was identified nor implemented.
Documentation:
None.
Outstanding items:
None