add updateable threshold sampler #2137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
PeterF778 reviewed Aug 20, 2025
| } else { | ||
| thresholdString = | ||
| ConsistentSamplingUtil.appendLast56BitHexEncodedWithoutTrailingZeros( | ||
| new StringBuilder(), threshold) |
Contributor
There was a problem hiding this comment.
Other static methods of ConsistentSamplingUtil are in the "import static", why this is different?
Contributor Author
There was a problem hiding this comment.
good point, thanks! Updated
PeterF778 approved these changes Aug 20, 2025
trask approved these changes Aug 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description:
Refactored the ConsistentFixedThresholdSampler class into a ConsistentThresholdSampler abstract class and ConsistentFixedThresholdSampler subclass, then added ConsistentVariableThresholdSampler class which is mutable
Existing Issue(s):
closes #2016
Testing:
Test class added for new updateable sampler.
Documentation:
ConsistentSampler additional public method has added documentation
Outstanding items:
Nothing obvious