Skip to content

Conversation

@SylvainJuge
Copy link
Contributor

Description:

Adds Solr to jmx-scraper

  • fix units for solr jmx metrics (in jmx scraper and jmx gatherer)
  • add solr tests + yaml metrics

Part of #1362

@SylvainJuge
Copy link
Contributor Author

This is currently failing due to a flaky wildfly test which is not related

WildflyIntegrationTest > endToEndTest(Path) FAILED org.opentest4j.AssertionFailedError: [no data point matched attribute set '[{server=default-server}, {listener=default}, {state=in}]' for metric 'wildfly.network.io'] expected: true but was: false at app//io.opentelemetry.contrib.jmxscraper.assertions.MetricAssert.lambda$hasDataPointsWithAttributes$2(MetricAssert.java:262) at app//io.opentelemetry.contrib.jmxscraper.assertions.MetricAssert.checkDataPoints(MetricAssert.java:188) at app//io.opentelemetry.contrib.jmxscraper.assertions.MetricAssert.hasDataPointsWithAttributes(MetricAssert.java:231) at app//io.opentelemetry.contrib.jmxscraper.target_systems.WildflyIntegrationTest.lambda$createMetricsVerifier$8(WildflyIntegrationTest.java:164) 

We will probably fix that in a separate PR, as it might require to relax a bit the metric assertions or wait for longer until the metric is properly reported.

Copy link
Contributor

@breedx-splk breedx-splk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Had just one small comment about unit and time vs. duration. Thanks!

@trask trask merged commit 5257aa0 into open-telemetry:main Dec 16, 2024
14 checks passed
@SylvainJuge SylvainJuge deleted the jmx-solr branch January 23, 2025 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants