Skip to content

Update Cassandra units for latency counters #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 12, 2021
Merged

Update Cassandra units for latency counters #111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
90f47e2
Update cassandra units
JonathanWamsley Oct 11, 2021
d366ec1
update cassandra descriptions
JonathanWamsley Oct 12, 2021
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions jmx-metrics/docs/target-systems/cassandra.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ These metrics are sourced from Cassandra's exposed Dropwizard Metrics for each n
* Instrument Type: DoubleValueObserver

* Name: `cassandra.client.request.range_slice.latency.count`
* Description: Total token range read request latency
* Unit: `µs`
* Description: Number of token range read request operations
* Unit: `1`
* Instrument Type: LongSumObserver

* Name: `cassandra.client.request.range_slice.latency.max`
Expand Down Expand Up @@ -48,8 +48,8 @@ These metrics are sourced from Cassandra's exposed Dropwizard Metrics for each n
* Instrument Type: DoubleValueObserver

* Name: `cassandra.client.request.read.latency.count`
* Description: Total standard read request latency
* Unit: `µs`
* Description: Number of standard read request operations
* Unit: `1`
* Instrument Type: LongSumObserver

* Name: `cassandra.client.request.read.latency.max`
Expand Down Expand Up @@ -78,8 +78,8 @@ These metrics are sourced from Cassandra's exposed Dropwizard Metrics for each n
* Instrument Type: DoubleValueObserver

* Name: `cassandra.client.request.write.latency.count`
* Description: Total regular write request latency
* Unit: `µs`
* Description: Number of regular write request operations
* Unit: `1`
* Instrument Type: LongSumObserver

* Name: `cassandra.client.request.write.latency.max`
Expand Down
12 changes: 6 additions & 6 deletions ...est/java/io/opentelemetry/contrib/jmxmetrics/target_systems/CassandraIntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,8 @@ void endToEnd() {
assertSum(
metric,
"cassandra.client.request.range_slice.latency.count",
"Total token range read request latency",
"µs"),
"Number of token range read request operations",
"1"),
metric ->
assertGauge(
metric,
Expand Down Expand Up @@ -88,8 +88,8 @@ void endToEnd() {
assertSum(
metric,
"cassandra.client.request.read.latency.count",
"Total standard read request latency",
"µs"),
"Number of standard read request operations",
"1"),
metric ->
assertGauge(
metric,
Expand Down Expand Up @@ -124,8 +124,8 @@ void endToEnd() {
assertSum(
metric,
"cassandra.client.request.write.latency.count",
"Total regular write request latency",
"µs"),
"Number of regular write request operations",
"1"),
metric ->
assertGauge(
metric,
Expand Down
6 changes: 3 additions & 3 deletions jmx-metrics/src/main/resources/target-systems/cassandra.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ otel.instrument(clientRequestRangeSliceLatency,

otel.instrument(clientRequestRangeSliceLatency,
"cassandra.client.request.range_slice.latency.count",
"Total token range read request latency", "µs", "Count",
"Number of token range read request operations", "1", "Count",
otel.&longCounterCallback)

otel.instrument(clientRequestRangeSliceLatency,
Expand Down Expand Up @@ -64,7 +64,7 @@ otel.instrument(clientRequestReadLatency,

otel.instrument(clientRequestReadLatency,
"cassandra.client.request.read.latency.count",
"Total standard read request latency", "µs", "Count",
"Number of standard read request operations", "1", "Count",
otel.&longCounterCallback)

otel.instrument(clientRequestReadLatency,
Expand Down Expand Up @@ -98,7 +98,7 @@ otel.instrument(clientRequestWriteLatency,

otel.instrument(clientRequestWriteLatency,
"cassandra.client.request.write.latency.count",
"Total regular write request latency", "µs", "Count",
"Number of regular write request operations", "1", "Count",
otel.&longCounterCallback)

otel.instrument(clientRequestWriteLatency,
Expand Down