Update Cassandra units for latency counters #111
Conversation
| otel.instrument(clientRequestRangeSliceLatency, | ||
| "cassandra.client.request.range_slice.latency.count", | ||
| "Total token range read request latency", "µs", "Count", | ||
| "Total token range read request latency", "1", "Count", |
There was a problem hiding this comment.
Is it a good time to update the description too? Seems to not be accurate - I'd expect "total latency" to be temporal since it's still latency
There was a problem hiding this comment.
Yeah, description names should be updated too.
| @JonathanWamsley, where in the cassandra documentation are you seeing this? The 3.11 monitoring docs say latency is in microseconds: http://cassandra.apache.org/doc/3.11.3/operating/metrics.html#metric-types |
| @rmfitzpatrick From where you linked, if you click through This article has an image that shows that the "Latency" timer has a "Count" inside of it. Separately, the "TotalLatency" counter would be needed to collect the total latency measured in microseconds. For additional confidence, other monitoring solutions have also reached this conclusion as well. |
This is a legacy solution this offering is intending to replace, and I appreciate you pointing this out! My oversight. |
4 participants
Description:
Update Cassandra metrics latency counter units to better reflect what is being collected.
Testing:
Updated Cassandra Integration Test
Documentation:
Updated Cassandra Docs