Skip to content

Bring ALPS ODLS up to par regarding wdir. #3310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 12, 2017
Merged

Bring ALPS ODLS up to par regarding wdir. #3310

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
36ac54b
Bring ALPS ODLS up to par regarding wdir.
Apr 10, 2017
af3a6e1
Verify that the chdir(2) succeeds.
Apr 11, 2017
27fa8aa
Hardcode basename to "orted" for error reporting.
Apr 11, 2017
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions orte/mca/odls/alps/odls_alps_module.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,6 +423,11 @@ static int do_child(orte_odls_spawn_caddy_t *cd, int write_fd)
sigprocmask(0, 0, &sigs);
sigprocmask(SIG_UNBLOCK, &sigs, 0);

/* take us to the correct wdir */
if (NULL != cd->wdir) {
chdir(cd->wdir);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to see this handle the case that chdir returns with error.
Copy link
Contributor Author

@marksantcroos marksantcroos Apr 10, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't disagree strongly, although I think your request is already covered by the call to orte_util_check_context_cwd() (https://github.com/open-mpi/ompi/blob/master/orte/util/context_fns.c#L56).

Note that my addition is mirroring the existing code in the default ODLS module (https://github.com/open-mpi/ompi/blob/master/orte/mca/odls/default/odls_default_module.c#L417).
}

/* Exec the new executable */

if (10 < opal_output_get_verbosity(orte_odls_base_framework.framework_output)) {
Expand Down