ofi: Fix Coverity warnings

Fix two coverity warnings: - Uninitialized variables (UNINIT) in /opal/mca/common/ofi/common_ofi.c: 859 in opal_common_ofi_select_provider() - Null pointer dereferences (FORWARD_NULL) /opal/mca/common/ofi/common_ofi.c: 636 in is_near() Move the "near" parameter in opal_common_ofi_select_provider() outside the #if OPAL_OFI_PCI_DATA_AVAILABLE block, because later in the code it's being used outside of it. Signed-off-by: Amir Shehata <shehataa@ornl.gov>

Author: amirshehataornl

opal/mca/common/ofi/common_ofi.c

@@ -633,9 +633,9 @@ static bool is_near(pmix_device_distance_t *distances,
  ret = sscanf(distances[i].uuid, "fab://%256s::%256s", lnguid, lsguid);
  if (ret != 2)
  continue;
- if (0 == strcasecmp(lnguid, nguid)) {
+ if (nguid && (0 == strcasecmp(lnguid, nguid))) {
  return true;
- } else if (0 == strcasecmp(lsguid, sguid)) {
+ } else if (sguid && (0 == strcasecmp(lsguid, sguid))) {
  return true;
  }
  }
@@ -772,8 +772,8 @@ struct fi_info *opal_common_ofi_select_provider(struct fi_info *provider_list,
  pmix_value_t *pmix_val;
  struct fi_pci_attr pci;
  int num_distances = 0;
- bool near;
 #endif
+ bool near = false;
  int ret;
  unsigned int num_provider = 0, provider_limit = 0;
  bool provider_found = false;