fix: reconnect, tests

Signed-off-by: Todd Baert <toddbaert@gmail.com>

Author: toddbaert

libs/providers/flagd-web/src/lib/flagd-web-provider.spec.ts

@@ -168,7 +168,7 @@ describe(FlagdWebProvider.name, () => {
  const mockPromiseClient = new MockPromiseClient() as unknown as PromiseClient<typeof Service>;
  OpenFeature.setProvider(
  new FlagdWebProvider(
- { host: 'fake.com' },
+ { host: 'fake.com', maxRetries: -1 },
  console,
  mockPromiseClient,
  mockCallbackClient as unknown as CallbackClient<typeof Service>
@@ -221,7 +221,7 @@ describe(FlagdWebProvider.name, () => {
  });
  });
 
- describe.skip('reconnect logic', () => {
+ describe('reconnect logic', () => {
  describe('Infinite maxRetries', () => {
  it('should attempt reconnect many times', (done) => {
  const mockCallbackClient = new MockCallbackClient();
@@ -239,7 +239,7 @@ describe(FlagdWebProvider.name, () => {
  });
  setTimeout(() => {
  try {
- expect(mockCallbackClient.eventStream.mock.calls.length).toBeGreaterThanOrEqual(4);
+ expect(mockCallbackClient.eventStream.mock.calls.length).toBeGreaterThanOrEqual(3);
  done();
  } catch (err) {
  done(err);
@@ -274,7 +274,7 @@ describe(FlagdWebProvider.name, () => {
  }, RECONNECT_TIME_LIMIT);
  });
 
- it('should NOT attempt reconnect if maxRetries (0) times', (done) => {
+ it('should NOT attempt reconnect if maxRetries (-1) times', (done) => {
  const mockCallbackClient = new MockCallbackClient();
  OpenFeature.setProvider(
  new FlagdWebProvider(

libs/providers/flagd-web/src/lib/flagd-web-provider.ts

@@ -27,7 +27,7 @@ export const ERROR_DISABLED = 'DISABLED';
 
 const EVENT_CONFIGURATION_CHANGE = 'configuration_change';
 const EVENT_PROVIDER_READY = 'provider_ready';
-const BACK_OFF_MULTIPLIER =- 3;
+const BACK_OFF_MULTIPLIER = 2;
 
 const INITIAL_DELAY_MS = 100;
 type AnyFlagResolutionType = typeof AnyFlag.prototype.value.case;
@@ -108,7 +108,7 @@ export class FlagdWebProvider implements Provider {
  private async retryConnect(context: EvaluationContext) {
  this._delayMs = Math.min(this._delayMs * BACK_OFF_MULTIPLIER, this._maxDelay);
 
- return new Promise<void>((resolve, reject) => {
+ return new Promise<void>((resolve) => {
  this._callbackClient.eventStream(
  {},
  (message) => {
@@ -129,13 +129,13 @@ export class FlagdWebProvider implements Provider {
  }
  },
  () => {
- reject();
  this._logger?.error(`${FlagdWebProvider.name}: could not establish connection to flagd`);
  if (this._retry < this._maxRetries) {
  this._retry++;
  setTimeout(() => this.retryConnect(context), this._delayMs);
  } else {
  this._logger?.warn(`${FlagdWebProvider.name}: max retries reached`);
+ this.events.emit(ProviderEvents.Error);
  }
  }
  );