feat: flow instead of exceptions in resolver #942
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
github-actions bot requested review from Kavindu-Dodan, beeme1mr, thisthat and toddbaert 
aepfli force-pushed the issue/Use_Details_rather_than_exceptions branch from 8961523 to ddae11d Compare 
| This should align with open-feature/java-sdk#1095 to avoid the loss of error hook invocations :) |
toddbaert changed the title 
toddbaert reviewed Sep 17, 2024
...rc/main/java/dev/openfeature/contrib/providers/flagd/resolver/process/InProcessResolver.java Outdated Show resolved Hide resolved
I think there's no behavioral change here, since even before the PR you mention, if errorCode was null we threw an exception to cause the error hook invokation. |
toddbaert approved these changes Sep 17, 2024
…g not found errors Exceptions are expensive GOTO statements, and in a performance relevant system not the best to be used for control flow . A FlagNotFound-Error can be expected, but the performance draw backs of exception in this case not. Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
…s/flagd/resolver/process/InProcessResolver.java Co-authored-by: Todd Baert <todd.baert@dynatrace.com> Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
aepfli force-pushed the issue/Use_Details_rather_than_exceptions branch from ae662d6 to 4dbb4c0 Compare Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
…g not found errors
Exceptions are expensive GOTO statements, and in a performance relevant system not the best to be used for control flow . A FlagNotFound-Error can be expected, but the performance draw backs of exception in this case not.
relates to: open-feature/java-sdk#1095