chore: update failing tests #732
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
toddbaert requested review from Kavindu-Dodan, beeme1mr, laliconfigcat and thisthat 
| @toddbaert please see #722 first |
| @liran2000 Oh, very sorry I missed this. I will take a look. |
toddbaert force-pushed the chore/fix-tests branch from 6712220 to 4ce0f4a Compare 
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
@liran2000 I merged the referenced request. It did take care of all the statsig issues. This fixes a remaining one in configcat, and makes some test vars private. |
beeme1mr approved these changes Apr 1, 2024
liran2000 approved these changes Apr 1, 2024
Kavindu-Dodan approved these changes Apr 1, 2024
This was referenced Apr 1, 2024
DBlanchard88 pushed a commit to DBlanchard88/java-sdk-contrib that referenced this pull request Apr 29, 2024
…t to ba1c241 (open-feature#732) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes some failing tests.
Some of these are due to the recent changes to automatically add targeting keys.