Skip to content

Conversation

markphelps
Copy link
Contributor

This PR

Related Issues

Closes: #636

Notes

Follow-up Tasks

How to test

@markphelps markphelps requested a review from a team as a code owner January 17, 2024 14:39
@github-actions github-actions bot requested a review from liran2000 January 17, 2024 14:39
@markphelps markphelps force-pushed the upgrade-flipt-provider branch from 1d0abcd to 516a3fc Compare January 17, 2024 14:40
@markphelps
Copy link
Contributor Author

@liran2000 could you help me debug why CI is failing please? It seems to be potentially getting a 500 from wiremock?

 Unrecognized token 'Request' 

https://github.com/open-feature/java-sdk-contrib/actions/runs/7560459925/job/20586536492?pr=638#step:6:15445

Copy link
Member

@liran2000 liran2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, sure.
Added review comments. Could not add changes to the PR, I tested the changes and it passes the tests locally at the IDE.

Signed-off-by: Mark Phelps <209477+markphelps@users.noreply.github.com>
@markphelps markphelps force-pushed the upgrade-flipt-provider branch from 01d9f72 to 45d2faf Compare January 19, 2024 14:10
@toddbaert
Copy link
Member

I'm seeing:

Warning: Javadoc Warnings Warning: [WARNING] warning: unknown enum constant Mode.PROPERTIES Warning: reason: class file for com.fasterxml.jackson.annotation.JsonCreator$Mode not found Warning: [WARNING] warning: unknown enum constant Include.NON_EMPTY Warning: reason: class file for com.fasterxml.jackson.annotation.JsonInclude$Include not found Warning: [WARNING] warning: unknown enum constant Mode.PROPERTIES 

I'll try to look into this on monday... looks like it might be warnings coming from a dependency 🤔

Signed-off-by: Mark Phelps <209477+markphelps@users.noreply.github.com>
@markphelps markphelps force-pushed the upgrade-flipt-provider branch from 3c8f8ec to f6c10c9 Compare January 23, 2024 17:27
@toddbaert toddbaert closed this Jan 25, 2024
@toddbaert toddbaert reopened this Jan 25, 2024
Signed-off-by: Mark Phelps <209477+markphelps@users.noreply.github.com>
Signed-off-by: Mark Phelps <209477+markphelps@users.noreply.github.com>
…java-sdk-contrib into upgrade-flipt-provider * 'upgrade-flipt-provider' of https://github.com/flipt-io/java-sdk-contrib: chore(flipt): bump flipt dep refactor(flipt): upgrade Flipt provider to use latest 1.0.0 Flipt SDK
@toddbaert toddbaert merged commit 42738b8 into open-feature:main Jan 26, 2024
@markphelps markphelps deleted the upgrade-flipt-provider branch January 26, 2024 21:17
@markphelps
Copy link
Contributor Author

Thanks all!! Much appreciated!

DBlanchard88 pushed a commit to DBlanchard88/java-sdk-contrib that referenced this pull request Apr 29, 2024
…ure#638) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants