- Notifications
You must be signed in to change notification settings - Fork 58
fix(flagd): fix wrong environment variable and test execution #1589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(flagd): fix wrong environment variable and test execution #1589
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @aepfli, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on refining the configuration and testing infrastructure for the flagd provider. It addresses an inconsistency in an environment variable name and removes an obsolete one, ensuring a cleaner and more accurate configuration. Additionally, it includes a minor version bump for the Maven Surefire plugin to maintain up-to-date testing dependencies.
Highlights
- Environment Variable Correction: The environment variable
SOURCE_PROVIDER_ID_ENV_VAR_NAME
has been renamed toPROVIDER_ID_ENV_VAR_NAME
for clarity and consistency within the flagd provider configuration. - Obsolete Environment Variable Removal: The
MAX_EVENT_STREAM_RETRIES_ENV_VAR_NAME
environment variable, which was no longer in use, has been removed from the flagd configuration. - Maven Surefire Plugin Update: The
maven-surefire-plugin
has been updated from version3.5.3
to3.5.4
, which may include minor bug fixes or improvements for test execution.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point by creating a comment using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands on the current page.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review | Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary | Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. |
Help | /gemini help | Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request addresses a couple of issues in the flagd
provider. It corrects a wrong environment variable name from FLAGD_SOURCE_PROVIDER_ID
to FLAGD_PROVIDER_ID
and removes an unused constant, which improves code clarity. Additionally, it bumps the version of the maven-surefire-plugin
, which, as per the PR title, is intended to fix test execution. The changes are consistent and well-contained. Overall, this is a good contribution that improves correctness and maintainability.
ba0e191
to 1e400be
Compare providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/FlagdOptions.java Show resolved Hide resolved
feca15d
to 0d95bca
Compare Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
1b636f5
to 39afdf4
Compare Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
39afdf4
to 85ca651
Compare /gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request addresses two main points: correcting an environment variable for the flagd provider and fixing test execution. The environment variable FLAGD_SOURCE_PROVIDER_ID
has been correctly renamed to FLAGD_PROVIDER_ID
, with backward compatibility thoughtfully maintained for the old variable. An unused environment variable constant has also been removed, improving code cleanliness. On the testing side, the maven-surefire-plugin
has been updated, and test code has been refactored to use the non-deprecated HookContext.from()
factory method. Overall, the changes are well-implemented and improve the codebase.
see cucumber/cucumber-jvm#2984