fix: Use seconds instead of milliseconds #1174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
kayukin changed the title …proxy logs a warning about this. Signed-off-by: Konstantin Kayukin <kayukin@gmail.com>
thomaspoignant approved these changes Jan 23, 2025
There was a problem hiding this comment.
Hey @kayukin thanks a lot for you pull request.
I forgot to update the Java provider when we added the warn log.
Thanks a lot for your contribution 🚀.
@thomaspoignant You are welcome! Thank you for your work. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Use seconds instead of milliseconds, since version 1.40.0 relay proxy logs a warning about this.
https://github.com/thomaspoignant/go-feature-flag/releases/tag/v1.40.0