fix: rpc caching not behaving as expected (cleared too often) #1115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
github-actions bot requested review from Kavindu-Dodan, beeme1mr, thisthat and toddbaert 
aepfli force-pushed the feat/gherkin-rework branch 7 times, most recently from d2b3cd4 to 910031e Compare aepfli force-pushed the feat/gherkin-rework branch 2 times, most recently from 4489649 to d61effe Compare aepfli force-pushed the feat/gherkin-rework branch 2 times, most recently from b349cc3 to 0a3b414 Compare Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
aepfli force-pushed the feat/gherkin-rework branch 2 times, most recently from 5822abc to 5678da0 Compare aepfli changed the title aepfli force-pushed the feat/gherkin-rework branch 2 times, most recently from 6afae99 to 838b248 Compare aepfli force-pushed the feat/gherkin-rework branch 2 times, most recently from 2a4cd90 to 07052a0 Compare This was referenced Jan 15, 2025
| All dependencies are resolved. Ready to merge ;) |
Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
aepfli force-pushed the feat/gherkin-rework branch from 07052a0 to ff5bccf Compare 
warber reviewed Jan 16, 2025
...ure/contrib/providers/flagd/resolver/process/storage/connector/grpc/GrpcStreamConnector.java Show resolved Hide resolved
…s/flagd/resolver/process/storage/connector/grpc/GrpcStreamConnector.java Co-authored-by: warber <72415058+warber@users.noreply.github.com> Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
chrfwow reviewed Jan 16, 2025
providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/FlagdProvider.java Outdated Show resolved Hide resolved
providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/FlagdProvider.java Outdated Show resolved Hide resolved
providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/FlagdProvider.java Outdated Show resolved Hide resolved
providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/FlagdProvider.java Show resolved Hide resolved
providers/flagd/src/test/java/dev/openfeature/contrib/providers/flagd/e2e/steps/EventSteps.java Show resolved Hide resolved
providers/flagd/src/test/java/dev/openfeature/contrib/providers/flagd/e2e/RunRpcTest.java Show resolved Hide resolved
providers/flagd/src/test/java/dev/openfeature/contrib/providers/flagd/e2e/RunInProcessTest.java Show resolved Hide resolved
providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/FlagdProvider.java Outdated Show resolved Hide resolved
aepfli force-pushed the feat/gherkin-rework branch 2 times, most recently from 8e2aeae to 70ee2fa Compare Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
aepfli force-pushed the feat/gherkin-rework branch from 70ee2fa to 338f367 Compare 
aepfli force-pushed the feat/gherkin-rework branch 2 times, most recently from 30e5f82 to a67b36c Compare chrfwow requested changes Jan 17, 2025
providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/FlagdProvider.java Outdated Show resolved Hide resolved
Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
aepfli force-pushed the feat/gherkin-rework branch from a67b36c to a14931f Compare chrfwow approved these changes Jan 20, 2025
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
| I pushed one more small change to move all the volatile fields on the provider into a dedicated object to be used as the intrinsic lock in our synchronized blocks. I think this has the benefit of being very clear but also it unifies all our locking onto a single object. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
With this pull request, I am fixing a regression within the RPC provider. We cleared the cache when there was an error, but we had to wait until we hit the error state and not stay in the stale state for the clean to happen. I also used this to normalize the eventing a little bit and reduce the complexity.
Additionally, I updated the e2e tests to the newest Gherkin version: