feat: Support JSON Serialize for Value #529
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Signed-off-by: Weihan Li <weihanli@outlook.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@ ## main #529 +/- ## ========================================== + Coverage 87.88% 88.18% +0.30% ========================================== Files 48 49 +1 Lines 1972 2049 +77 Branches 222 239 +17 ========================================== + Hits 1733 1807 +74 Misses 191 191 - Partials 48 51 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Weihan Li <weihanli@outlook.com>
Signed-off-by: Weihan Li <weihanli@outlook.com>
WeihanLi changed the title Signed-off-by: Weihan Li <weihanli@outlook.com>
Signed-off-by: Weihan Li <weihanli@outlook.com>
Signed-off-by: Weihan Li <weihanli@outlook.com>
Signed-off-by: Weihan Li <weihanli@outlook.com>
Signed-off-by: Weihan Li <weihanli@outlook.com>
WeihanLi force-pushed the value-to-json-string branch from 5f8cb12 to 7c217aa Compare …st data Signed-off-by: Weihan Li <weihanli@outlook.com>
Signed-off-by: Weihan Li <weihanli@outlook.com>
WeihanLi force-pushed the value-to-json-string branch from cdf97d4 to 2ca8dd0 Compare 
WeihanLi commented Jul 24, 2025
Signed-off-by: Weihan Li <weihanli@outlook.com>
Signed-off-by: Weihan Li <weihanli@outlook.com>
Signed-off-by: Weihan Li <weihanli@outlook.com>
Signed-off-by: Weihan Li <weihanli@outlook.com>
kylejuliandev approved these changes Jul 24, 2025
askpt approved these changes Jul 24, 2025
Member
askpt left a comment
askpt left a comment There was a problem hiding this comment.
LGTM! Thanks for your contribution.
This was referenced Dec 22, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR
ValueJsonConverterto support STJ JSON SerializeRelated Issues
Fixes #517
Notes
ValueJsonConverterto support STJ JSON Serialize, keep itinternalfor now, think we could make itpublicwhen necessaryFollow-up Tasks
ToJsonString()method likes LD SDK?Valueto a strong-typedT?How to test
refer to the unit test cases