Skip to content
This repository was archived by the owner on Sep 30, 2025. It is now read-only.

Commit 8f34a80

Browse files
authored
Fix if in GHA for changing the stable environment and test prettify (#289)
* Fix if in GHA for changing the stable environment * Trigger prettify
1 parent 6212669 commit 8f34a80

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

.github/workflows/changeStableEnv.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,13 +21,13 @@ jobs:
2121
- name: Read sdfabric ONOS image from stable env
2222
run: echo ONOS_IMAGE=$(cat .env.stable | grep "ONOS_IMAGE="| sed "s/ONOS_IMAGE=//") >> $GITHUB_ENV
2323
- name: Pull latest sdfabric ONOS image
24-
if: ${{ env.ONOS_IMAGE }} == 'sdfabric-onos-local:master'
24+
if: ${{ env.ONOS_IMAGE == 'sdfabric-onos-local:master' }}
2525
run: docker pull opennetworking/sdfabric-onos:master
2626
- name: Get sdfabric ONOS latest
27-
if: ${{ env.ONOS_IMAGE }} == 'sdfabric-onos-local:master'
27+
if: ${{ env.ONOS_IMAGE == 'sdfabric-onos-local:master' }}
2828
run: echo SDFABRIC_ONOS_LATEST_SHA=$(docker inspect --format='{{index .RepoDigests 0}}' opennetworking/sdfabric-onos:master) >> $GITHUB_ENV
2929
- name: Cleanup stable env file
30-
if: ${{ env.ONOS_IMAGE }} == 'sdfabric-onos-local:master'
30+
if: ${{ env.ONOS_IMAGE == 'sdfabric-onos-local:master' }}
3131
run: |
3232
sed -i "/ONOS_VERSION=.*/d" ".env.stable"
3333
sed -i "/TRELLIS_CONTROL_VERSION=.*/d" ".env.stable"
@@ -37,7 +37,7 @@ jobs:
3737
# For last sed you must use a different delimiter than /, @ or :
3838
# Those are included in env.SDFABRIC_ONOS_LATEST_SHA
3939
- name: Create pull request
40-
if: ${{ env.ONOS_IMAGE }} == 'sdfabric-onos-local:master'
40+
if: ${{ env.ONOS_IMAGE == 'sdfabric-onos-local:master' }}
4141
uses: peter-evans/create-pull-request@v3
4242
with:
4343
token: ${{ secrets.ONF_BOT_GH_TOKEN }}

ptf/tests/upf.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,8 @@ def runTest(self):
5757
self.testPacket(pkt, app_filtering)
5858

5959
@autocleanup
60-
def testPacket(self, pkt, app_filtering, app_bitrate=None, session_bitrate=None,
60+
def testPacket(self, pkt, app_filtering, app_bitrate=None,
61+
session_bitrate=None,
6162
slice_bitrate=None):
6263

6364
if gtp.GTP_U_Header not in pkt:

0 commit comments

Comments
 (0)