Skip to content

Support Slevomat conding standard v5 #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Support Slevomat conding standard v5 #85

wants to merge 2 commits into from

Conversation

@soullivaneuh
Copy link

@soullivaneuh soullivaneuh commented Feb 18, 2019

Should not cause any issue as your ruleset does not set any rules from Slevomat.

BTW, why requiring it? It can apparently be installed separately.
@TomasVotruba
Copy link
Contributor

TomasVotruba commented Feb 18, 2019 •
edited
Loading

See https://github.com/object-calisthenics/phpcs-calisthenics-rules/search?q=Slevomat&unscoped_q=Slevomat

Please bump to single version only - ^5.0. It's not really core package to maintain multiple version of it, like Symfony.
@TomasVotruba TomasVotruba self-requested a review February 21, 2019 20:33
@jeroennoten
Copy link
Contributor

jeroennoten commented Mar 11, 2019

Now Symplify updated dependencies, we can update to Slevomat coding standard 5.0: #87
@TomasVotruba
Copy link
Contributor

TomasVotruba commented Mar 11, 2019

Replaced by #87

@soullivaneuh Thank you for your initial PR 👍
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@soullivaneuh @TomasVotruba @jeroennoten