Skip to content

Conversation

@rohanvakharia
Copy link

I have removed packages dependency so that it can be used directly without composer install

@TomasVotruba
Copy link
Contributor

TomasVotruba commented Feb 21, 2020

This is composer package, so it's designed to be used with composer install.
I won't accept this change, as it kills the main ideas of package re-use.

What is the real issue you try to solve?

@rohanvakharia
Copy link
Author

rohanvakharia commented Feb 21, 2020

I haven't removed composer. I just removed package dependency so that it can be added as installed_paths in phpcs from anywhere.

@TomasVotruba
Copy link
Contributor

TomasVotruba commented Feb 21, 2020

I know. Yet changes kills dependency idea behind composer.

Bad design of PHP_CodeSniffer cannot make all ruleset remove dependencies.

@TomasVotruba
Copy link
Contributor

I recommend using ECS, there is no such problem.

@rohanvakharia
Copy link
Author

I will fix those phpcs errors, though I feel that remove those packages will open up additional and easy way to add this standard while coding. Users can add in the editor and check the calisthenics errors while coding itself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants