Skip to content

Conversation

@nikolicaleksa
Copy link
Contributor

Q A
Bug fix? no
New feature? yes
Fixed tickets -

This PR is adding / changing a couple of things:

  • New insight for method cyclomatic complexity
  • New insight for class method-average cyclomatic complexity
  • Change how we calculate complexity score
    • Old: Based on total average complexity per method
    • New: 100% - percentage of files with problems where total number of files is Complexity insights count multiplied by number of files
@nikolicaleksa
Copy link
Contributor Author

@cmgmyr @nunomaduro Can I get a review on this?

@snmatsui
Copy link

This is what I really wanted.

@snmatsui
Copy link

@nikolicaleksa Do you plan to correct this CI failure?

@nikolicaleksa
Copy link
Contributor Author

@nikolicaleksa Do you plan to correct this CI failure?

Pipeline was failing due to some other changes, not the ones I introduced. Anyways, PHPInsights is (unofficially) deprecated so I don't think this will ever get merged.

@snmatsui
Copy link

snmatsui commented Feb 4, 2025

Anyways, PHPInsights is (unofficially) deprecated so I don't think this will ever get merged.

@nikolicaleksa
If you don't mind, please let me know where you read that PHPInsights has been deprecated.
(I know the official site is down...)

@nikolicaleksa
Copy link
Contributor Author

Anyways, PHPInsights is (unofficially) deprecated so I don't think this will ever get merged.

@nikolicaleksa If you don't mind, please let me know where you read that PHPInsights has been deprecated. (I know the official site is down...)

I've asked Nuno while he was streaming (https://www.twitch.tv/enunomaduro), and he said that the project is more-or-less abandoned, as can also be seen by issues / PRs/ commits.

@snmatsui
Copy link

snmatsui commented Feb 5, 2025

Thank you very much.
I didn't know he has Twitch channel.

@nunomaduro nunomaduro merged commit d4d8c09 into nunomaduro:master Mar 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants