fix(envs): revert behavior of array in npm config #194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
package.json: ``` { "config": { "array": [ "item1", "item2", "item3" ] }} ``` Before: ``` { "npm_package_config_array": "item1\n\nitem2\n\nitem3" } ``` After ``` { "npm_package_config_array_0": "item1", "npm_package_config_array_1": "item2", "npm_package_config_array_2": "item3" } ``` 
lukekarrys previously approved these changes Jan 22, 2024
lukekarrys approved these changes Jan 22, 2024
Merged
wraithgar pushed a commit that referenced this pull request Jan 23, 2024
🤖 I have created a release *beep* *boop* --- ## [7.0.4](v7.0.3...v7.0.4) (2024-01-22) ### Bug Fixes * [`7ebc853`](7ebc853) [#194](#194) envs: revert behavior of array in npm config (#194) (@wraithgar, @siemhesda) * [`bf5f419`](bf5f419) [#192](#192) code formatting (@wraithgar) * [`b6f7f93`](b6f7f93) [#192](#192) remove unreachable code path (@wraithgar) * [`865d556`](865d556) [#192](#192) remove is-windows test fixture code from module (@wraithgar) * [`c47a91a`](c47a91a) [#192](#192) update code to use @npmcli/run-script (@wraithgar) ### Dependencies * [`648b0ed`](648b0ed) [#192](#192) remove read-package-json-fast * [`04a4600`](04a4600) [#192](#192) add `@npmcli/package-json@5.0.0` ### Chores * [`155c434`](155c434) [#192](#192) rewrite tests (@wraithgar) * [`64a3503`](64a3503) [#192](#192) add spawk (@wraithgar) * [`b47b660`](b47b660) [#192](#192) remove require-inject (@wraithgar) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Reverts environment parsing of config arrays to use indexed names
instead of joining them with double newlines. That change appears to
have been introduced when the enviromnent values were added back into
npm, but not in the same way they were done before.
Fixes: npm/cli#3775
Credit: @siemhesda