Skip to content

Conversation

@nlf
Copy link
Contributor

@nlf nlf commented Jun 21, 2022

No description provided.

@nlf nlf requested a review from a team as a code owner June 21, 2022 19:56
@nlf nlf force-pushed the nlf/deps-run-script-4.1.0 branch from 09b23b8 to 26a2855 Compare June 21, 2022 21:24
@nlf nlf force-pushed the nlf/deps-run-script-4.1.0 branch from 26a2855 to 2841706 Compare June 21, 2022 21:50
@fritzy fritzy merged commit 3e28f3c into latest Jun 22, 2022
@fritzy fritzy deleted the nlf/deps-run-script-4.1.0 branch June 22, 2022 20:46
@fritzy fritzy mentioned this pull request Jun 22, 2022
@ljharb
Copy link
Contributor

ljharb commented Sep 20, 2022

This was a breaking change in arborist, because it raised the engines requirement from 12.13 to 12.22 due to npm/run-script#76.

Possible solutions:

  1. downgrade @npmcli/run-script to v3 in all the packages that had bumped to v4 prematurely
  2. node-gyp 9 could drop its version requirement from node v12.22 to node v12.13 and publish a patch
ljharb referenced this pull request in ljharb/npm-lockfile Sep 20, 2022
ljharb added a commit to ljharb/aud that referenced this pull request Sep 20, 2022
Specifically, updating to `@npmcli/run-script` v4, which requires node-gyp 9, which requires node v12.22, instead of v12.13 See npm/cli#5049
ljharb added a commit to ljharb/get-dep-tree that referenced this pull request Sep 27, 2022
ljharb added a commit to ljharb/ls-publishers that referenced this pull request Oct 27, 2022
…er`, `yargs` Pin arborist and pacote due to a breaking change; see npm/cli#5049 (comment) / npm/run-script#76
ljharb added a commit to ljharb/ls-publishers that referenced this pull request Oct 27, 2022
… `yargs` Pin arborist and pacote due to a breaking change; see npm/cli#5049 (comment) / npm/run-script#76
ljharb added a commit to ljharb/publishers that referenced this pull request Oct 28, 2022
…but pin due to a breaking change; see npm/cli#5049 (comment) / npm/cli#5049 (comment)
ljharb added a commit to ljharb/aud that referenced this pull request Dec 19, 2022
ljharb added a commit to ljharb/npm-lockfile that referenced this pull request Dec 19, 2022
ljharb added a commit to ljharb/get-dep-tree that referenced this pull request Dec 19, 2022
ljharb added a commit to ljharb/ls-publishers that referenced this pull request Dec 19, 2022
@ljharb
Copy link
Contributor

ljharb commented Dec 19, 2022

This was fixed in nodejs/node-gyp#2771 and released in node-gyp v9.3.1. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants