fix(query): properly return :missing nodes (#7320)

Fixes #7316

Author: wraithgar

lib/commands/query.js

@@ -113,10 +113,12 @@ class Query extends BaseCommand {
  // builds a normalized inventory
  buildResponse (items) {
  for (const node of items) {
- if (!this.#seen.has(node.target.location)) {
+ if (!node.target.location || !this.#seen.has(node.target.location)) {
  const item = new QuerySelectorItem(node)
  this.#response.push(item)
- this.#seen.add(item.location)
+ if (node.target.location) {
+ this.#seen.add(item.location)
+ }
  }
  }
  }

tap-snapshots/test/lib/commands/query.js.test.cjs

@@ -99,6 +99,31 @@ exports[`test/lib/commands/query.js TAP linked node > should return linked node
 ]
 `
 
+exports[`test/lib/commands/query.js TAP missing > should return missing node 1`] = `
+[
+ {
+ "name": "b",
+ "version": "^1.0.0",
+ "_id": "b@^1.0.0",
+ "pkgid": "b@^1.0.0",
+ "path": null,
+ "realpath": null,
+ "resolved": null,
+ "from": [
+ ""
+ ],
+ "to": [],
+ "dev": true,
+ "inBundle": false,
+ "deduped": false,
+ "overridden": false,
+ "queryContext": {
+ "missing": true
+ }
+ }
+]
+`
+
 exports[`test/lib/commands/query.js TAP package-lock-only with package lock > should return valid response with only lock info 1`] = `
 [
  {

test/lib/commands/query.js

@@ -320,3 +320,25 @@ t.test('expect entries', t => {
  })
  t.end()
 })
+
+t.test('missing', async t => {
+ const { npm, joinedOutput } = await loadMockNpm(t, {
+ prefixDir: {
+ node_modules: {
+ a: {
+ name: 'a',
+ version: '1.0.0',
+ },
+ },
+ 'package.json': JSON.stringify({
+ name: 'project',
+ dependencies: {
+ a: '^1.0.0',
+ b: '^1.0.0',
+ },
+ }),
+ },
+ })
+ await npm.exec('query', [':missing'])
+ t.matchSnapshot(joinedOutput(), 'should return missing node')
+})

workspaces/arborist/lib/query-selector-all.js

@@ -257,7 +257,12 @@ class Results {
  for (const edge of node.edgesOut.values()) {
  if (edge.missing) {
  const pkg = { name: edge.name, version: edge.spec }
- res.push(new this.#targetNode.constructor({ pkg }))
+ const item = new this.#targetNode.constructor({ pkg })
+ item.queryContext = {
+ missing: true,
+ }
+ item.edgesIn = new Set([edge])
+ res.push(item)
  }
  }
  return res