Skip to content

Commit a30e7cd

Browse files
authored
fix: Remove unused variable service_account in safer-cluster to avoid confusion (terraform-google-modules#448)
1 parent ce401d9 commit a30e7cd

File tree

5 files changed

+0
-20
lines changed

5 files changed

+0
-20
lines changed

autogen/safer-cluster/variables.tf.tmpl

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -214,12 +214,6 @@ variable "registry_project_id" {
214214
default = ""
215215
}
216216

217-
variable "service_account" {
218-
type = string
219-
description = "The service account to run nodes as if not overridden in `node_pools`. The create_service_account variable default value (true) will cause a cluster-specific service account to be created."
220-
default = ""
221-
}
222-
223217
variable "cluster_resource_labels" {
224218
type = map(string)
225219
description = "The GCE resource labels (a map of key/value pairs) to be applied to the cluster"

modules/safer-cluster-update-variant/README.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -241,7 +241,6 @@ For simplicity, we suggest using `roles/container.admin` and
241241
| registry\_project\_id | Project holding the Google Container Registry. If empty, we use the cluster project. If grant_registry_access is true, storage.objectViewer role is assigned on this project. | string | `""` | no |
242242
| resource\_usage\_export\_dataset\_id | The dataset id for which network egress metering for this cluster will be enabled. If enabled, a daemonset will be created in the cluster to meter network egress traffic. | string | `""` | no |
243243
| sandbox\_enabled | (Beta) Enable GKE Sandbox (Do not forget to set `image_type` = `COS_CONTAINERD` and `node_version` = `1.12.7-gke.17` or later to use it). | bool | `"false"` | no |
244-
| service\_account | The service account to run nodes as if not overridden in `node_pools`. The create_service_account variable default value (true) will cause a cluster-specific service account to be created. | string | `""` | no |
245244
| skip\_provisioners | Flag to skip all local-exec provisioners. It breaks `stub_domains` and `upstream_nameservers` variables functionality. | bool | `"false"` | no |
246245
| stub\_domains | Map of stub domains and their resolvers to forward DNS queries for a certain domain to an external DNS server | map(list(string)) | `<map>` | no |
247246
| subnetwork | The subnetwork to host the cluster in | string | n/a | yes |

modules/safer-cluster-update-variant/variables.tf

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -214,12 +214,6 @@ variable "registry_project_id" {
214214
default = ""
215215
}
216216

217-
variable "service_account" {
218-
type = string
219-
description = "The service account to run nodes as if not overridden in `node_pools`. The create_service_account variable default value (true) will cause a cluster-specific service account to be created."
220-
default = ""
221-
}
222-
223217
variable "cluster_resource_labels" {
224218
type = map(string)
225219
description = "The GCE resource labels (a map of key/value pairs) to be applied to the cluster"

modules/safer-cluster/README.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -241,7 +241,6 @@ For simplicity, we suggest using `roles/container.admin` and
241241
| registry\_project\_id | Project holding the Google Container Registry. If empty, we use the cluster project. If grant_registry_access is true, storage.objectViewer role is assigned on this project. | string | `""` | no |
242242
| resource\_usage\_export\_dataset\_id | The dataset id for which network egress metering for this cluster will be enabled. If enabled, a daemonset will be created in the cluster to meter network egress traffic. | string | `""` | no |
243243
| sandbox\_enabled | (Beta) Enable GKE Sandbox (Do not forget to set `image_type` = `COS_CONTAINERD` and `node_version` = `1.12.7-gke.17` or later to use it). | bool | `"false"` | no |
244-
| service\_account | The service account to run nodes as if not overridden in `node_pools`. The create_service_account variable default value (true) will cause a cluster-specific service account to be created. | string | `""` | no |
245244
| skip\_provisioners | Flag to skip all local-exec provisioners. It breaks `stub_domains` and `upstream_nameservers` variables functionality. | bool | `"false"` | no |
246245
| stub\_domains | Map of stub domains and their resolvers to forward DNS queries for a certain domain to an external DNS server | map(list(string)) | `<map>` | no |
247246
| subnetwork | The subnetwork to host the cluster in | string | n/a | yes |

modules/safer-cluster/variables.tf

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -214,12 +214,6 @@ variable "registry_project_id" {
214214
default = ""
215215
}
216216

217-
variable "service_account" {
218-
type = string
219-
description = "The service account to run nodes as if not overridden in `node_pools`. The create_service_account variable default value (true) will cause a cluster-specific service account to be created."
220-
default = ""
221-
}
222-
223217
variable "cluster_resource_labels" {
224218
type = map(string)
225219
description = "The GCE resource labels (a map of key/value pairs) to be applied to the cluster"

0 commit comments

Comments
 (0)