Fix: Change for_each splat syntax on update variants, closes terraform-google-modules#414 (terraform-google-modules#415)

* Fix iterating over splat in google_container_node_pool with for_each * Regenerate private-cluster-update-variant submodules

Author: skinlayers

README.md

@@ -12,8 +12,7 @@ Sub modules are provided from creating private clusters, beta private clusters,
 
 ## Compatibility
 
-This module is meant for use with Terraform 0.12.
-If you haven't
+This module is meant for use with Terraform 0.12. If you haven't
 [upgraded][terraform-0.12-upgrade] and need a Terraform
 0.11.x-compatible version of this module, the last released version
 intended for Terraform 0.11.x is [3.0.0].

autogen/main/cluster.tf.tmpl

@@ -343,7 +343,7 @@ resource "google_container_node_pool" "pools" {
  {% endif %}
  for_each = local.node_pools
  {% if update_variant %}
- name = random_id.name.*.hex[each.key]
+ name = {for k, v in random_id.name : k => v.hex}[each.key]
  {% else %}
  name = each.key
  {% endif %}

modules/beta-private-cluster-update-variant/cluster.tf

@@ -310,7 +310,7 @@ resource "random_id" "name" {
 resource "google_container_node_pool" "pools" {
  provider = google-beta
  for_each = local.node_pools
- name = random_id.name.*.hex[each.key]
+ name = { for k, v in random_id.name : k => v.hex }[each.key]
  project = var.project_id
  location = local.location
  // use node_locations if provided, defaults to cluster level node_locations if not specified

modules/private-cluster-update-variant/cluster.tf

@@ -210,7 +210,7 @@ resource "random_id" "name" {
 resource "google_container_node_pool" "pools" {
  provider = google
  for_each = local.node_pools
- name = random_id.name.*.hex[each.key]
+ name = { for k, v in random_id.name : k => v.hex }[each.key]
  project = var.project_id
  location = local.location