mirror_cmd for users to do their own mirror url replacing

Author: jasonkarns

bin/node-build

@@ -202,6 +202,13 @@ matches_platform() {
  [ "${platform[2]}-${platform[0]}" = "$match" ]
 }
 
+mirror() {
+ local package_url="$1"
+ local checksum="$2"
+
+ echo "${package_url/https:\/\/nodejs.org\/dist/$NODE_BUILD_MIRROR_URL}"
+}
+
 try_binary(){
  [ -n "$BINARY_URL" ] && [ -z "$SKIP_BINARY" ] && [ -z "$BINARY_ATTEMPT" ]
 }
@@ -443,8 +450,8 @@ fetch_tarball() {
  checksum="${package_url#*#}"
  package_url="${package_url%%#*}"
 
- if [ -n "$NODE_BUILD_MIRROR_URL" ]; then
- mirror_url="${package_url/https:\/\/nodejs.org\/dist/$NODE_BUILD_MIRROR_URL}"
+ if [ -z "$NODE_BUILD_SKIP_MIRROR" ]; then
+ mirror_url="$("${NODE_BUILD_MIRROR_CMD:=mirror}" $package_url $checksum)"
  fi
  fi
 
@@ -905,14 +912,10 @@ WGET_OPTS="${NODE_BUILD_WGET_OPTS} ${IPV4+--inet4-only} ${IPV6+--inet6-only}"
 
 NODE_BUILD_MIRROR_URL="${NODE_BUILD_MIRROR_URL%/}"
 
-if ! has_checksum_support compute_sha2; then
+if ! has_checksum_support compute_sha2 || [ -z "$NODE_BUILD_MIRROR_URL" ]; then
  NODE_BUILD_SKIP_MIRROR=true
 fi
 
-if [ -n "$NODE_BUILD_SKIP_MIRROR" ] || [ -z "$NODE_BUILD_MIRROR_URL" ]; then
- unset NODE_BUILD_MIRROR_URL
-fi
-
 SEED="$(date "+%Y%m%d%H%M%S").$$"
 LOG_PATH="${TMP}/node-build.${SEED}.log"
 NODE_BIN="${PREFIX_PATH}/bin/node"

test/mirror.bats

@@ -4,6 +4,7 @@ load test_helper
 export NODE_BUILD_SKIP_MIRROR=
 export NODE_BUILD_CACHE_PATH=
 export NODE_BUILD_MIRROR_URL=http://mirror.example.com
+export NODE_BUILD_MIRROR_CMD=mirror_stub
 export NODE_BUILD_CURL_OPTS=
 
 setup() {
@@ -15,7 +16,6 @@ setup() {
  stub curl "-q -o * -*S* http://example.com/* : cp $FIXTURE_ROOT/\${5##*/} \$3"
 
  install_fixture definitions/without-checksum
- echo "$output" >&2
 
  assert_success
  assert [ -x "${INSTALL_ROOT}/bin/package" ]
@@ -45,12 +45,14 @@ setup() {
  stub shasum true "echo $checksum"
  stub curl "-*I* $mirror_url : true" \
  "-q -o * -*S* $mirror_url : cp $FIXTURE_ROOT/package-1.0.0.tar.gz \$3"
+ stub mirror_stub ": echo $mirror_url"
 
  install_fixture definitions/with-checksum
 
  assert_success
  assert [ -x "${INSTALL_ROOT}/bin/package" ]
 
+ unstub mirror_stub
  unstub curl
  unstub shasum
 }
@@ -63,12 +65,14 @@ setup() {
  stub shasum true "echo $checksum"
  stub curl "-*I* $mirror_url : false" \
  "-q -o * -*S* http://example.com/* : cp $FIXTURE_ROOT/\${5##*/} \$3"
+ stub mirror_stub ": echo $mirror_url"
 
  install_fixture definitions/with-checksum
 
  assert_success
  assert [ -x "${INSTALL_ROOT}/bin/package" ]
 
+ unstub mirror_stub
  unstub curl
  unstub shasum
 }
@@ -82,13 +86,14 @@ setup() {
  stub curl "-*I* $mirror_url : true" \
  "-q -o * -*S* $mirror_url : cp $FIXTURE_ROOT/package-1.0.0.tar.gz \$3" \
  "-q -o * -*S* http://example.com/* : cp $FIXTURE_ROOT/\${5##*/} \$3"
+ stub mirror_stub ": echo $mirror_url"
 
  install_fixture definitions/with-checksum
- echo "$output" >&2
 
  assert_success
  assert [ -x "${INSTALL_ROOT}/bin/package" ]
 
+ unstub mirror_stub
  unstub curl
  unstub shasum
 }