repl: Failed to save editor mode text in .save command

[princejwesley]

Checklist

• make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
• tests and/or benchmarks are included
• commit message follows commit guidelines

Affected core subsystem(s)

repl

Description of change

Fixes: #8142

Note: This pull request depends on #8143 to merge in order to pass the test.

[cjihrig]

assert.strictEqual() please.

[jasnell]

LGTM with green CI

[Fishrock123]

sounds like a tiny feature to me

if you think otherwise, remove the label I guess

[princejwesley]

CI: https://ci.nodejs.org/job/node-test-pull-request/3755/

[addaleax]

CI is green except for one build bot failure.

LGTM, and I think this can pass as as semver-patch change.

[jasnell]

I'd say semver-patch. It seems obvious to me that this should have worked before but it was just missed.

[princejwesley]

@addaleax Is it good for merging or one more attempt for CI green?

[addaleax]

@princejwesley I think this is good to go. 👍

[princejwesley]

Landed in f6a7434

[bnoordhuis]

The status line for this commit is not great. Its goal is to inform the reader what changed and why but repl: Failed to save editor mode text in .save doesn't do that, IMO - it only hints vaguely at a bug somewhere.

The lack of commit log exacerbates it. The only way to divine what really changed is to look at the diff.

[princejwesley]

@bnoordhuis Shall I amend the commit with below description ?

.save command is not capturing code executed in .editor mode. This PR addresses it

Sorry, I should have added it in the first place

[bnoordhuis]

Too late now, we're well outside the 10 minute rule. :-)

[yorkie]

Introducing a rebasing and pre-review before landing might avoid this kind of issue again?