deps: cherry-pick 7bd24767 from v8 upstream (v6.x) #8078
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Original commit message: Version 5.1.281.65 (cherry-pick) Merged 85b8c2dc4aee1031ac02f9d7c02d5c1aa76bc2ba Fix observable array access when formatting stack trace. BUG=chromium:617527 LOG=N R=hablich@chromium.org Review URL: https://codereview.chromium.org/2051383002 . Cr-Commit-Position: refs/branch-heads/5.1@{nodejs#76} Cr-Branched-From: 167dc63b4c9a1d0f0fe1b19af93644ac9a561e83-refs/heads/5.1.281@{nodejs#1} Cr-Branched-From: 03953f52bd4a184983a551927c406be6489ef89b-refs/heads/master@{nodejs#35282}
Member
| LGTM |
1 similar comment
Member
| LGTM |
Contributor
| LGTM. Don't bother changing this for this PR, but it might be marginally preferrable to cherry-pick the original fix (v8/v8@85b8c2d) rather than the merge-to-5.1-commit (v8/v8@7bd2476). The commit message is a little bit clearer with the former. |
fhinkel added a commit to fhinkel/node that referenced this pull request Aug 17, 2016
Original commit message: Version 5.1.281.65 (cherry-pick) Merged 85b8c2dc4aee1031ac02f9d7c02d5c1aa76bc2ba Fix observable array access when formatting stack trace. BUG=chromium:617527 LOG=N R=hablich@chromium.org Review URL: https://codereview.chromium.org/2051383002 . Cr-Commit-Position: refs/branch-heads/5.1@{nodejs#76} Cr-Branched-From: 167dc63b4c9a1d0f0fe1b19af93644ac9a561e83-refs/heads/5.1.281@{nodejs#1} Cr-Branched-From: 03953f52bd4a184983a551927c406be6489ef89b-refs/heads/master@{nodejs#35282} PR-URL: nodejs#8078 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Member Author
| Landed in 08e2b04. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX) passesAffected core subsystem(s)
deps V8
Description of change
Original commit message:
/cc @nodejs/v8