Skip to content

Conversation

@Trott
Copy link
Member

@Trott Trott commented Apr 2, 2016

Pull Request check-list

  • Is the commit message formatted according to [CONTRIBUTING.md][0]?

Affected core subsystem(s)

doc

Description of change

Provide encrypted links to freenode IRC.

Provide encrypted links to freenode IRC.
@Trott Trott added the doc Issues and PRs related to the documentations. label Apr 2, 2016
@jasnell
Copy link
Member

jasnell commented Apr 2, 2016

LGTM

@stevemao
Copy link
Contributor

stevemao commented Apr 2, 2016

cc @nodejs/documentation

@Knighton910
Copy link

LGTM

2 similar comments
@r-52
Copy link
Contributor

r-52 commented Apr 2, 2016

LGTM

@benjamingr
Copy link
Member

LGTM

jasnell pushed a commit that referenced this pull request Apr 4, 2016
Provide encrypted links to freenode IRC. PR-URL: #6019 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Klauke <romaaan.git@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@jasnell
Copy link
Member

jasnell commented Apr 4, 2016

Landed in 68bd702

@jasnell jasnell closed this Apr 4, 2016
MylesBorins pushed a commit that referenced this pull request Apr 5, 2016
Provide encrypted links to freenode IRC. PR-URL: #6019 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Klauke <romaaan.git@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
This was referenced Apr 5, 2016
MylesBorins pushed a commit that referenced this pull request Apr 11, 2016
Provide encrypted links to freenode IRC. PR-URL: #6019 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Klauke <romaaan.git@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Apr 11, 2016
@Trott Trott deleted the good branch January 13, 2022 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations.

7 participants