build: don't install github templates

[jbergstroem]

• Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with
  this change (including linting)?
• Is the commit message formatted according to [CONTRIBUTING.md][0]?
• If this change fixes a bug (or a performance problem), is a regression
  test (or a benchmark) included?
• Is a documentation update included (if this change modifies
  existing APIs, or introduces new ones)?

Affected core subsystem(s)

build

Description of change

Avoid putting github templates in the source tarballs.

/cc @nodejs/build

[rvagg]

lgtm on this individual change.

We also have these in the top level:

.editorconfig
.eslintignore
.eslintrc
.gitattributes
.gitignore
.mailmap
android-configure
AUTHORS
BSDmakefile
CHANGELOG.md
CODE_OF_CONDUCT.md
COLLABORATOR_GUIDE.md
common.gypi
configure
CONTRIBUTING.md
GOVERNANCE.md
LICENSE
Makefile
node.gyp
README.md
ROADMAP.md
vcbuild.bat
WORKING_GROUPS.md

I wouldn't mind getting rid of .editorconfig, .gitattributes, .gitignore, .mailmap, CODE_OF_CONDUCT.md, COLLABORATOR_GUIDE.md, CONTRIBUTING.md, GOVERNANCE.md, ROADMAP.md, WORKING_GROUPS.md. I don't think they add anything valuable to a user downloading a source tarball. @nodejs/build @nodejs/ctc thoughts on why any of these should be kept in the source tarball?

[Trott]

CODE_OF_CONDUCT.md, COLLABORATOR_GUIDE.md, CONTRIBUTING.md, and GOVERNANCE.md are linked (with relative paths) in the README.md. I'd be inclined to keep them.

Removing GitHub templates from the tarball change: LGTM

[jasnell]

+1 to keeping CODE_OF_CONDUCT.md, COLLABORATOR_GUIDE.md, CONTRIBUTING.md and GOVERNANCE.md. The others I'm good with excluding.

[jbergstroem]

@rvagg will open open a discussion that aims to target what a tarball (vs git clone) should contain.

[bnoordhuis]

Apropos the README, people that download the binaries frequently get confused about the build instructions in it. Perhaps it's better to distribute an abridged version in release tarballs, then we can drop the other *.md files too.

[Trott]

Apropos the README, people that download the binaries frequently get confused about the build instructions in it. Perhaps it's better to distribute an abridged version in release tarballs, then we can drop the other *.md files too.

I've certainly thought before that it might be good to either move all build instructions to a separate file or else minimize the instructions in the README and having detailed instructions in a separate file. I'm talking about in the repo, not just tarballs.