-
- Notifications
You must be signed in to change notification settings - Fork 33.8k
tools: add support for subkeys in release tools #4807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3c6a93f to af1f38c Compare af1f38c to 3bf7733 Compare tools/release.sh Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not 100% we want to be using the -E flag here. Personally I don't see a problem, but perhaps we want to solve this without using an extended regular expression
| As a note, my subkey works, but it always prints the |
| Any thoughts on this @rvagg ? |
| Yeah, this works, I was working up a complicated solution in my head but the fact that this simply prompts you to choose makes it a simple fix! Good thinking.
lgtm with that change. |
3bf7733 to 403659f Compare 403659f to c219ad1 Compare | @rvagg I added the change and rebased against master |
c219ad1 to 726bea7 Compare | lgtm, I think you can probably land this at will now, thanks @thealphanerd! |
Replace grep with awk to add support for subkeys PR-URL: nodejs#4807 Reviewed-By: Rod Vagg <rod@vagg.org>
| Landed in 321162d |
726bea7 to 321162d Compare Replace grep with awk to add support for subkeys PR-URL: #4807 Reviewed-By: Rod Vagg <rod@vagg.org>
Replace grep with awk to add support for subkeys PR-URL: nodejs#4807 Reviewed-By: Rod Vagg <rod@vagg.org>
Replace grep with awk to add support for subkeys PR-URL: #4807 Reviewed-By: Rod Vagg <rod@vagg.org>
Replace grep with awk to add support for subkeys PR-URL: #4807 Reviewed-By: Rod Vagg <rod@vagg.org>
Replace grep with awk to add support for subkeys PR-URL: nodejs#4807 Reviewed-By: Rod Vagg <rod@vagg.org>
Replace grep with awk to add support for subkeys PR-URL: nodejs#4807 Reviewed-By: Rod Vagg <rod@vagg.org>
Replace grep with awk to add support for subkeys PR-URL: nodejs#4807 Reviewed-By: Rod Vagg <rod@vagg.org>
Replace grep with awk to add support for subkeys
/cc @rvagg @jasnell @Fishrock123 @nodejs/build