deps: fix libuv for android #46746
Merged
deps: fix libuv for android #46746
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
| Review requested:
|
nodejs-github-bot added libuv 
richardlau approved these changes Feb 20, 2023
cjihrig approved these changes Feb 20, 2023
bnoordhuis approved these changes Feb 20, 2023
Member
bnoordhuis left a comment
bnoordhuis left a comment There was a problem hiding this comment.
Can probably be fast-tracked?
bnoordhuis added the fast-track 
Contributor
| Fast-track has been requested by @bnoordhuis. Please 👍 to approve. |
addaleax approved these changes Feb 20, 2023
addaleax added the author ready 
anonrig approved these changes Feb 20, 2023
anonrig added the commit-queue nodejs-github-bot added commit-queue-failed Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/46746 ✔ Done loading data for nodejs/node/pull/46746 ----------------------------------- PR info ------------------------------------ Title deps: fix libuv for android (#46746) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch nappy:nappy-patch-1 -> nodejs:main Labels libuv, fast-track, author ready, needs-ci Commits 1 - deps: fix libuv for android Committers 1 - GitHub PR-URL: https://github.com/nodejs/node/pull/46746 Fixes: https://github.com/nodejs/node/issues/46743 Fixes: https://github.com/nodejs/node/issues/46744 Reviewed-By: Luigi Pinca Reviewed-By: Richard Lau Reviewed-By: Colin Ihrig Reviewed-By: Ben Noordhuis Reviewed-By: Anna Henningsen Reviewed-By: Yagiz Nizipli ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/46746 Fixes: https://github.com/nodejs/node/issues/46743 Fixes: https://github.com/nodejs/node/issues/46744 Reviewed-By: Luigi Pinca Reviewed-By: Richard Lau Reviewed-By: Colin Ihrig Reviewed-By: Ben Noordhuis Reviewed-By: Anna Henningsen Reviewed-By: Yagiz Nizipli -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 20 Feb 2023 13:50:11 GMT ✔ Approvals: 6 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/46746#pullrequestreview-1306031079 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/46746#pullrequestreview-1306054082 ✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/46746#pullrequestreview-1306069521 ✔ - Ben Noordhuis (@bnoordhuis): https://github.com/nodejs/node/pull/46746#pullrequestreview-1306278383 ✔ - Anna Henningsen (@addaleax): https://github.com/nodejs/node/pull/46746#pullrequestreview-1306349810 ✔ - Yagiz Nizipli (@anonrig): https://github.com/nodejs/node/pull/46746#pullrequestreview-1306419569 ℹ This PR is being fast-tracked ✔ Last GitHub CI successful ✖ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/4227754655 |
anonrig added request-ci 
github-actions bot removed the request-ci This comment was marked as outdated.
This comment was marked as outdated.
RaisinTen approved these changes Feb 21, 2023
Collaborator
Contributor Author
| Profile updated |
bnoordhuis added commit-queue nodejs-github-bot added commit-queue-failed Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/46746 ✔ Done loading data for nodejs/node/pull/46746 ----------------------------------- PR info ------------------------------------ Title deps: fix libuv for android (#46746) Author Julian Dropmann (@nappy, first-time contributor) Branch nappy:nappy-patch-1 -> nodejs:main Labels libuv, fast-track, author ready Commits 1 - deps: fix libuv for android Committers 1 - GitHub PR-URL: https://github.com/nodejs/node/pull/46746 Fixes: https://github.com/nodejs/node/issues/46743 Fixes: https://github.com/nodejs/node/issues/46744 Reviewed-By: Luigi Pinca Reviewed-By: Richard Lau Reviewed-By: Colin Ihrig Reviewed-By: Ben Noordhuis Reviewed-By: Anna Henningsen Reviewed-By: Yagiz Nizipli Reviewed-By: Darshan Sen ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/46746 Fixes: https://github.com/nodejs/node/issues/46743 Fixes: https://github.com/nodejs/node/issues/46744 Reviewed-By: Luigi Pinca Reviewed-By: Richard Lau Reviewed-By: Colin Ihrig Reviewed-By: Ben Noordhuis Reviewed-By: Anna Henningsen Reviewed-By: Yagiz Nizipli Reviewed-By: Darshan Sen -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 20 Feb 2023 13:50:11 GMT ✔ Approvals: 7 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/46746#pullrequestreview-1306031079 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/46746#pullrequestreview-1306054082 ✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/46746#pullrequestreview-1306069521 ✔ - Ben Noordhuis (@bnoordhuis): https://github.com/nodejs/node/pull/46746#pullrequestreview-1306278383 ✔ - Anna Henningsen (@addaleax): https://github.com/nodejs/node/pull/46746#pullrequestreview-1306349810 ✔ - Yagiz Nizipli (@anonrig): https://github.com/nodejs/node/pull/46746#pullrequestreview-1306419569 ✔ - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/46746#pullrequestreview-1306753762 ℹ This PR is being fast-tracked ✖ Last GitHub CI failed ℹ Last Full PR CI on 2023-02-21T06:30:04Z: https://ci.nodejs.org/job/node-test-pull-request/49816/ - Querying data for job/node-test-pull-request/49816/ ✔ Last Jenkins CI successful ⚠ PR author is a new contributor: @nappy(julian@dropmann.org) ⚠ - commit b738caed4282 is authored by 56575+nappy@users.noreply.github.com -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/4232081092 |
Member
| @nappy you may want to update and force-push your commit so it has you as the author instead of users.noreply.github.com. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Fix android build errors introduced by the upgrade to libuv 1.44.2 Fixes: nodejs#46743 Fixes: nodejs#46744
richardlau added request-ci github-actions bot removed the request-ci This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
github-actions bot removed the request-ci Collaborator
34 tasks
Collaborator
richardlau approved these changes Feb 22, 2023
richardlau added the commit-queue nodejs-github-bot removed the commit-queue Collaborator
| Landed in ee22706 |
31 tasks
targos pushed a commit that referenced this pull request Mar 13, 2023
Fix android build errors introduced by the upgrade to libuv 1.44.2 Fixes: #46743 Fixes: #46744 PR-URL: #46746 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
Fix android build errors introduced by the upgrade to libuv 1.44.2 Fixes: #46743 Fixes: #46744 PR-URL: #46746 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fix android build errors introduced by the upgrade to libuv 1.44.2
Fixes: #46743
Fixes: #46744