v14.21.0 proposal #44889
Merged
v14.21.0 proposal #44889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This commit adds a new command line option named '--openssl-shared-config' intended to allow reverting to the old OpenSSL configuration behavior where Node.js would use the configuration section name (called appname in OpenSSL) 'openssl_conf' which could potentially be used my other applications.. PR-URL: #43124 Refs: #40366 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Backport-PR-URL: #43782 Refs: nodejs/nodejs.org#4713 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
PR-URL: #43402 Backport-PR-URL: #43760 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
PR-URL: #44509 Backport-PR-URL: #43760 Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Feng Yu <F3n67u@outlook.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
nodejs-github-bot added dependencies 
danielleadams force-pushed the v14.21.0-proposal branch from 0b230e3 to c6fa3ad Compare 
Collaborator
19 tasks
danielleadams force-pushed the v14.21.0-proposal branch from c6fa3ad to 742cf5d Compare Collaborator
VoltrexKeyva added release 25 tasks
Contributor Author
| I forgot to update the commit date. I'll do that. |
Member
Gracias Danielle! |
This was referenced Oct 7, 2022
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
15 tasks
RafaelGSS approved these changes Oct 11, 2022
19 tasks
Member
| We could potentially include |
PR-URL: #45094 Refs: nodejs/Release#773 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
PR-URL: #44775 Backport-PR-URL: #44924 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Refs: #43929 (comment) PR-URL: #43954 Backport-PR-URL: #45126 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Feng Yu <F3n67u@outlook.com>
Original commit log follows: darwin: remove EPROTOTYPE error workaround (libuv/libuv#3405) It's been reported in the past that OS X 10.10, because of a race condition in the XNU kernel, sometimes returns a transient EPROTOTYPE error when trying to write to a socket. Libuv handles that by retrying the operation until it succeeds or fails with a different error. Recently it's been reported that current versions of the operating system formerly known as OS X fail permanently with EPROTOTYPE under certain conditions, resulting in an infinite loop. Because Apple isn't exactly forthcoming with bug fixes or even details, I'm opting to simply remove the workaround and have the error bubble up. Refs: libuv/libuv#482 Fixes: #43916 PR-URL: #43950 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Original commit log follows: darwin: translate EPROTOTYPE to ECONNRESET (libuv/libuv#3413) macOS versions 10.10 and 10.15 - and presumbaly 10.11 to 10.14, too - have a bug where a race condition causes the kernel to return EPROTOTYPE because the socket isn't fully constructed. It's probably the result of the peer closing the connection and that is why libuv translates it to ECONNRESET. Previously, libuv retried until the EPROTOTYPE error went away but some VPN software causes the same behavior except the error is permanent, not transient, turning the retry mechanism into an infinite loop. Refs: libuv/libuv#482 Refs: libuv/libuv#3405 Fixes: #43916 PR-URL: #43950 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Member
|
danielleadams force-pushed the v14.21.0-proposal branch from a94b49b to 613eb9e Compare PR-URL: #41939 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams force-pushed the v14.21.0-proposal branch from 613eb9e to f7e5f28 Compare Collaborator
Collaborator
richardlau approved these changes Nov 1, 2022
danielleadams added a commit to nodejs/nodejs.org that referenced this pull request Nov 1, 2022
danielleadams added a commit to nodejs/nodejs.org that referenced this pull request Nov 1, 2022
lucshi pushed a commit to lucshi/node that referenced this pull request Nov 9, 2022
Notable changes: * deps: * update corepack to 0.14.2 (Node.js GitHub Bot) nodejs#44775 * src: * add --openssl-shared-config option (Daniel Bevenius) nodejs#43124 PR-URL: nodejs#44889
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
2022-11-01, Version 14.21.0 'Fermium' (LTS), @danielleadams
Notable changes
Commits
773f587912] - deps: cherry-pick libuv/libuv@3a7b955 (Ben Noordhuis) #43950a1dea66956] - deps: cherry-pick libuv/libuv@abb109f (Ben Noordhuis) #4395098c49d81f5] - deps: update corepack to 0.14.2 (Node.js GitHub Bot) #4477518c43c8518] - deps: update timezone to tz2022e (Richard Lau) #45094a1f8e4db48] - deps: update corepack to 0.14.1 (Node.js GitHub Bot) #44704e55389ca86] - deps: update corepack to 0.14.0 (Node.js GitHub Bot) #445090227462418] - deps: update corepack to 0.13.0 (Node.js GitHub Bot) #44318ee24c320ea] - deps: update corepack to 0.12.3 (Node.js GitHub Bot) #4422928e9891449] - deps: update corepack to 0.12.2 (Node.js GitHub Bot) #44159b6972c9df2] - deps: update corepack to 0.12.1 (Node.js GitHub Bot) #439659d6cb3b5f1] - deps: update corepack to 0.12.0 (Node.js GitHub Bot) #43748fa6c276b4f] - deps: update Corepack to 0.11.2 (Maël Nison) #434024f83d75626] - (SEMVER-MAJOR) src,doc,test: add --openssl-shared-config option (Daniel Bevenius) #431249487028043] - test: fix intl tests on small-icu builds (Antoine du Hamel) #41939a1d52097f8] - tools: add more options to track flaky tests (Antoine du Hamel) #43954