[v10.x] n-api: backport ArrayBuffer detaching APIs #33061
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added c++ 
legendecas requested review from addaleax, cjihrig, devnexen, gabrielschulhof and jasnell legendecas changed the title napi_detach_arraybuffernapi_detach_arraybuffer 
Collaborator
Collaborator
Collaborator
Collaborator
Member Author
| /cc @nodejs/releasers would this be possible to be able to release in the next v10.x minor release? As far as I can tell, v10.x will begin maintenance state from 2020-05-19. I'm wondering if there will be a minor release before that? |
gabrielschulhof approved these changes Apr 29, 2020
gabrielschulhof added the semver-minor 
legendecas force-pushed the backport-29768-to-10 branch from 5ecd2b2 to fba7c05 Compare legendecas changed the title napi_detach_arraybuffer Member Author
| @gabrielschulhof updated :). Since |
Collaborator
cjihrig approved these changes May 3, 2020
Collaborator
Collaborator
lundibundi approved these changes May 5, 2020
Collaborator
codebytere approved these changes May 7, 2020
Collaborator
Member
| @legendecas Please could you rebase this onto the current v10.x-staging branch? |
As ArrayBuffer#detach is an ecma spec operation ([Section 24.1.1.3](https://tc39.es/ecma262/#sec-detacharraybuffer)), it might be good to have it in N-API. Fixes nodejs#29674 PR-URL: nodejs#29768 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
This implements ArrayBuffer#IsDetachedBuffer operation as per ECMAScript specification Section 24.1.1.2 https://tc39.es/ecma262/#sec-isdetachedbuffer Closes: nodejs#29955 PR-URL: nodejs#30613 Fixes: nodejs#29955 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
As its actual release stage. PR-URL: nodejs#30703 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
legendecas force-pushed the backport-29768-to-10 branch from e40b224 to 5ba1e7f Compare This comment has been minimized.
This comment has been minimized.
Collaborator
richardlau approved these changes Jul 1, 2020
richardlau pushed a commit that referenced this pull request Jul 1, 2020
As ArrayBuffer#detach is an ecma spec operation ([Section 24.1.1.3](https://tc39.es/ecma262/#sec-detacharraybuffer)), it might be good to have it in N-API. Fixes: #29674 PR-URL: #29768 Backport-PR-URL: #33061 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
richardlau pushed a commit that referenced this pull request Jul 1, 2020
This implements ArrayBuffer#IsDetachedBuffer operation as per ECMAScript specification Section 24.1.1.2 https://tc39.es/ecma262/#sec-isdetachedbuffer Closes: #29955 PR-URL: #30613 Backport-PR-URL: #33061 Fixes: #29955 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Member
| Landed in 3dbd8cd...5dab101 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR backports ArrayBuffer detaching related N-API to v10.x, commits:
n-api: add
napi_detach_arraybufferAs ArrayBuffer#detach is an ecma spec operation
(Section 24.1.1.3),
it might be good to have it in N-API.
Fixes #29674
PR-URL: #29768
Reviewed-By: Anna Henningsen anna@addaleax.net
Reviewed-By: David Carlier devnexen@gmail.com
Reviewed-By: Colin Ihrig cjihrig@gmail.com
Reviewed-By: James M Snell jasnell@gmail.com
Reviewed-By: Gabriel Schulhof gabriel.schulhof@intel.com
n-api: implement napi_is_detached_arraybuffer
This implements ArrayBuffer#IsDetachedBuffer operation as per ECMAScript
specification Section 24.1.1.2 https://tc39.es/ecma262/#sec-isdetachedbuffer
Closes: #29955
PR-URL: #30613
Fixes: #29955
Reviewed-By: Anna Henningsen anna@addaleax.net
Reviewed-By: Gus Caplan me@gus.host
Reviewed-By: David Carlier devnexen@gmail.com
Reviewed-By: Chengzhong Wu legendecas@gmail.com
Reviewed-By: Michael Dawson michael_dawson@ca.ibm.com
doc,n-api: mark napi_detach_arraybuffer as experimental
As its actual release stage.
PR-URL: #30703
Reviewed-By: Denys Otrishko shishugi@gmail.com
Reviewed-By: Luigi Pinca luigipinca@gmail.com
Reviewed-By: Michael Dawson michael_dawson@ca.ibm.com
Reviewed-By: Tobias Nießen tniessen@tnie.de