src: fix indentation for AsyncResource #23177
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This un-breaks the linter, which currently does not seem to run on this part of the file.
nodejs-github-bot added the c++ 2 tasks
cjihrig approved these changes Sep 30, 2018
Member Author
| CI: https://ci.nodejs.org/job/node-test-pull-request/17534/ Please 👍 to approve fast-tracking (this unblocks #23178). |
joyeecheung approved these changes Sep 30, 2018
refack approved these changes Sep 30, 2018
lundibundi approved these changes Sep 30, 2018
lpinca approved these changes Sep 30, 2018
thefourtheye approved these changes Sep 30, 2018
Member Author
| Windows re-build: https://ci.nodejs.org/job/node-test-commit-windows-fanned/21149/ |
lundibundi added the author ready 
Member
| Windows resume: https://ci.nodejs.org/job/node-test-commit-windows-fanned/21171/ |
jasnell approved these changes Oct 1, 2018
BridgeAR approved these changes Oct 1, 2018
Member Author
| Landed in 69f1a2b |
addaleax added a commit that referenced this pull request Oct 2, 2018
This un-breaks the linter, which currently does not seem to run on this part of the file. PR-URL: #23177 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos pushed a commit that referenced this pull request Oct 3, 2018
This un-breaks the linter, which currently does not seem to run on this part of the file. PR-URL: #23177 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This was referenced Oct 10, 2018
This was referenced Oct 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This un-breaks the linter, which currently does not seem to run on this part of the file.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes