Skip to content

src: unique_ptrs in few lambdas in src/node_file.cc #23124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

src: unique_ptrs in few lambdas in src/node_file.cc #23124

wants to merge 1 commit into from

Conversation

@gireeshpunathil
Copy link
Member

@gireeshpunathil gireeshpunathil commented Sep 27, 2018

Few lambdas in src/node_file.cc uses conventional pointers, turn those into unique_ptr semantics.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
@gireeshpunathil
src: unique_ptrs in few lambdas
32b8aa0 
Few lambdas in src/node_file.cc uses conventional pointers, turn those into unique_ptr semantics
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 27, 2018

@gireeshpunathil build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1040/pipeline
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. labels Sep 27, 2018
@addaleax
Copy link
Member

addaleax commented Sep 30, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/17531/
@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 30, 2018
@danbev
Copy link
Contributor

danbev commented Oct 1, 2018

Landed in d407291.
@danbev danbev closed this Oct 1, 2018
danbev pushed a commit that referenced this pull request Oct 1, 2018
@gireeshpunathil @danbev
src: unique_ptrs in few lambdas
d407291 
Few lambdas in src/node_file.cc uses conventional pointers, turn those into unique_ptr semantics PR-URL: #23124 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos pushed a commit that referenced this pull request Oct 1, 2018
@gireeshpunathil @targos
src: unique_ptrs in few lambdas
d9c92bf 
Few lambdas in src/node_file.cc uses conventional pointers, turn those into unique_ptr semantics PR-URL: #23124 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos pushed a commit that referenced this pull request Oct 3, 2018
@gireeshpunathil @targos
src: unique_ptrs in few lambdas
7d7dc16 
Few lambdas in src/node_file.cc uses conventional pointers, turn those into unique_ptr semantics PR-URL: #23124 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@targos targos mentioned this pull request Oct 7, 2018
Merged
This was referenced Oct 10, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system.

8 participants

@gireeshpunathil @nodejs-github-bot @addaleax @danbev @jasnell @thefourtheye @cjihrig @tniessen