test: increase coverage for worker_threads #22942
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Trott added test 
Member Author
cjihrig approved these changes Sep 19, 2018
Trott force-pushed the worker-coverage branch from 384414d to 0364fa1 Compare 
Provide a test to cover adding setting `onmessage` to a non-function. This provides previously-missing coverage for an else block in the `onmessage` setter.
Trott force-pushed the worker-coverage branch from 0364fa1 to dcf1d8f Compare Member Author
| Pushed changes to add more comments explaining the test. |
addaleax approved these changes Sep 19, 2018
thefourtheye approved these changes Sep 19, 2018
jasnell approved these changes Sep 19, 2018
Member Author
| Resume Build: https://ci.nodejs.org/job/node-test-pull-request/17327/ |
Trott added the author ready Member Author
| Windows rebuild: https://ci.nodejs.org/job/node-test-commit-windows-fanned/20879/ ✔️ |
hiroppy approved these changes Sep 19, 2018
Contributor
Interesting... |
Member
Member Author
| Landed in c7bf02a |
Trott added a commit to Trott/io.js that referenced this pull request Sep 21, 2018
Provide a test to cover adding setting `onmessage` to a non-function. This provides previously-missing coverage for an else block in the `onmessage` setter. PR-URL: nodejs#22942 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
targos pushed a commit that referenced this pull request Sep 23, 2018
Provide a test to cover adding setting `onmessage` to a non-function. This provides previously-missing coverage for an else block in the `onmessage` setter. PR-URL: #22942 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
This was referenced Oct 10, 2018
This was referenced Oct 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Provide a test to cover adding setting
onmessageto a non-function.This provides previously-missing coverage for an else block in the
onmessagesetter.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes