util: escape symbol and non-enumerable keys #22300
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added the util 
Member Author
Member Author
| @nodejs/util PTAL |
These keys require escaping as they might also contain line breaks and other special characters.
BridgeAR force-pushed the fix-key-escaping branch from 06330a7 to c3f2bdc Compare Member Author
|
Rebased due to conflicts. |
BridgeAR requested review from TimothyGu, benjamingr, devsnek, jasnell and mcollina Member Author
| PTAL. This needs a review. |
jasnell approved these changes Aug 17, 2018
BridgeAR added the author ready 
benjamingr approved these changes Aug 17, 2018
Member
| Not sure about semverness, please run a citgm before landing. Nice find :) |
Member Author
| CITGM this PR https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1513/ ✔️ |
BridgeAR added a commit to BridgeAR/node that referenced this pull request Aug 19, 2018
These keys require escaping as they might also contain line breaks and other special characters. PR-URL: nodejs#22300 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Member Author
| Landed in a04f2f7 |
targos added backport-requested-v10.x and removed author ready 
Member
| Should this be backported to |
Member
| Landed easily after #21869 |
targos pushed a commit that referenced this pull request Aug 19, 2018
These keys require escaping as they might also contain line breaks and other special characters. PR-URL: #22300 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
targos pushed a commit that referenced this pull request Sep 3, 2018
These keys require escaping as they might also contain line breaks and other special characters. PR-URL: #22300 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
This was referenced Sep 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
These keys require escaping as they might also contain line breaks
and other special characters.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes