test: address flaky worker test #21893
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Trott added test 
Member Author
Member
| Hm – if I may offer an alternative? diff --git a/test/parallel/test-worker-message-port-transfer-closed.js b/test/parallel/test-worker-message-port-transfer-closed.js index 435a3789fca7..e3a13bfcbfe9 100644 --- a/test/parallel/test-worker-message-port-transfer-closed.js +++ b/test/parallel/test-worker-message-port-transfer-closed.js @@ -50,5 +50,9 @@ testSingle(port1, port2); port2.close(common.mustCall(testBothClosed)); testBothClosed(); -setTimeout(common.mustNotCall('The communication channel is still open'), - common.platformTimeout(1000)).unref(); +function tickUnref(n, fn) { + if (n === 0) return fn(); + setImmediate(tickUnref, n-1, fn).unref(); +} + +tickUnref(10, common.mustNotCall('The communication channel is still open'));This removes the timeout too, but we can keep the test in parallel this way… |
Member Author
| @addaleax SGTM. Do you want to open a PR for that change? Or would you prefer I put it into this one and move it back to parallel here? I'm fine either way, of course. |
Member
| @Trott either one is fine :) |
Make test/parallel/test-worker-message-port-transfer-closed.js more reliable by counting ticks rather than using a single setTimeout(). Fixes: nodejs#21892
Member Author
| Updated with @addaleax's suggestion. Re-running stress test to see if this PR passes: https://ci.nodejs.org/job/node-stress-single-test/1970/nodes=freebsd10-64/console Same stress test failing on master: https://ci.nodejs.org/job/node-stress-single-test/1967/nodes=freebsd10-64/console |
hiroppy approved these changes Jul 23, 2018
Member Author
Member Author
Trott added a commit to Trott/io.js that referenced this pull request Jul 24, 2018
Make test/parallel/test-worker-message-port-transfer-closed.js more reliable by counting ticks rather than using a single setTimeout(). Fixes: nodejs#21892 PR-URL: nodejs#21893 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Member Author
| Landed in f93a19b |
Merged
This was referenced Aug 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Move test/parallel/test-worker-message-port-transfer-closed.js to
sequential to avoid race condition with
setTimeout()at end of test.Fixes: #21892
/cc @TimothyGu
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes