tools: improve update-eslint.sh #21819
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
* Pin version numbers when using `npx`. This means we can be careful about updating what we run. (Thinking about the recent eslint-scope thing.) * Add removeNPMAbsolutePaths to get rid of unused fields in package.json files. These unused fields can cause unnecessary churn, as at least one contains an absolute path that will be different for each developer.
Member Author
| Ref: #21817 (comment) |
Member Author
| CI failure is clearly unrelated (this code does not get run in CI), but we should do a full run anyway: |
vsemozhetbyt approved these changes Jul 15, 2018
targos approved these changes Jul 15, 2018
| npx dmn@1.0.10 -f clean | ||
| # Use removeNPMAbsolutePaths to remove unused data in package.json. | ||
| # This avoids churn as absolute paths can change from one dev to another. | ||
| npx removeNPMAbsolutePaths@1.0.4 . |
Member
There was a problem hiding this comment.
There's really an npm module for everything :D
richardlau approved these changes Jul 15, 2018
lpinca approved these changes Jul 15, 2018
cjihrig approved these changes Jul 16, 2018
trivikr approved these changes Jul 16, 2018
silverwind approved these changes Jul 16, 2018
Trott added a commit to Trott/io.js that referenced this pull request Jul 20, 2018
* Pin version numbers when using `npx`. This means we can be careful about updating what we run. (Thinking about the recent eslint-scope thing.) * Add removeNPMAbsolutePaths to get rid of unused fields in package.json files. These unused fields can cause unnecessary churn, as at least one contains an absolute path that will be different for each developer. PR-URL: nodejs#21819 Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
Member Author
| Landed in 6ca5a8a |
targos pushed a commit that referenced this pull request Jul 20, 2018
* Pin version numbers when using `npx`. This means we can be careful about updating what we run. (Thinking about the recent eslint-scope thing.) * Add removeNPMAbsolutePaths to get rid of unused fields in package.json files. These unused fields can cause unnecessary churn, as at least one contains an absolute path that will be different for each developer. PR-URL: #21819 Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
Merged
This was referenced Aug 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
npx. This means we can be carefulabout updating what we run. (Thinking about the recent eslint-scope
thing.)
files. These unused fields can cause unnecessary churn, as at least
one contains an absolute path that will be different for each
developer.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes