Skip to content

Conversation

@shobhitchittora
Copy link
Contributor

Refs: #20400

  • documentation is changed or added
  • commit message follows [commit guidelines]
@nodejs-github-bot nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. labels May 3, 2018
@shobhitchittora
Copy link
Contributor Author

shobhitchittora commented May 3, 2018

@vsemozhetbyt here. I missed this change in the last PR. 😂

@vsemozhetbyt
Copy link
Contributor

As this is the same change as already landed for another doc fragment, Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@vsemozhetbyt
Copy link
Contributor

@tniessen
Copy link
Member

tniessen commented May 3, 2018

Nit: typo in commit message (can be fixed while landing)

@vsemozhetbyt vsemozhetbyt added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels May 3, 2018
@vsemozhetbyt
Copy link
Contributor

Landed in 5efbe4c
Thank you.

vsemozhetbyt pushed a commit that referenced this pull request May 7, 2018
PR-URL: #20500 Refs: #20400 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 8, 2018
PR-URL: #20500 Refs: #20400 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@MylesBorins MylesBorins mentioned this pull request May 8, 2018
MylesBorins pushed a commit that referenced this pull request May 8, 2018
PR-URL: #20500 Refs: #20400 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 9, 2018
PR-URL: #20500 Refs: #20400 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.

5 participants