doc: update and fixed doc/guides/writing-and-running-benchmarks.md #20379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
| cc @nodejs/benchmarking |
Contributor
vsemozhetbyt added the benchmark 
joyeecheung approved these changes Apr 28, 2018
trivikr approved these changes Apr 28, 2018
trivikr reviewed Apr 28, 2018
| string_decoder/string-decoder.js n=250000 chunk=1024 inlen=1024 encoding=base64-utf8 23.60 % *** 2.105625e-12 | ||
| string_decoder/string-decoder.js n=250000 chunk=1024 inlen=1024 encoding=utf8 14.04 % *** 1.291105e-07 | ||
| string_decoder/string-decoder.js n=250000 chunk=1024 inlen=128 encoding=ascii 6.70 % * 2.928003e-02 | ||
| confidence improvement accuracy (*) (**) (***) |
Member
There was a problem hiding this comment.
nit: The last three columns are not aligned in private branch:
Contributor Author
There was a problem hiding this comment.
Copy from console log，should I fixed it in doc?
Member
There was a problem hiding this comment.
doc might be using different whitespaces as compared to console.log
It's a nit, check if you can add some spaces to align the columns in the doc. When I ran benchmark script, the last three columns were aligned.
BridgeAR approved these changes Apr 29, 2018
BridgeAR added the author ready trivikr approved these changes May 3, 2018
Member
Member
Contributor Author
| Thanks for your help @trivikr |
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Refs: 368517c
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes