Skip to content

stream: only check options once in Duplex ctor #20353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

stream: only check options once in Duplex ctor #20353

wants to merge 1 commit into from

Conversation

@danbev
Copy link
Contributor

@danbev danbev commented Apr 27, 2018

This commit updates the Duplex constructor adding an if statement
checking if options is undefined, and removes the check from the
following three if statements.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@danbev
stream: only check options once in Duplex ctor
9fe915a 
This commit updates the Duplex constructor adding an if statement checking if options is undefined, and removes the check from the following three if statements.
@nodejs-github-bot nodejs-github-bot added the stream Issues and PRs related to the stream subsystem. label Apr 27, 2018
@danbev
Copy link
Contributor Author

danbev commented Apr 27, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/14539/
@BridgeAR BridgeAR added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Apr 27, 2018
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Apr 28, 2018
@danbev @BridgeAR
stream: only check options once in Duplex ctor
65021c5 
This commit updates the Duplex constructor adding an if statement checking if options is undefined, and removes the check from the following three if statements. PR-URL: nodejs#20353 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BridgeAR
Copy link
Member

BridgeAR commented Apr 28, 2018

Landed in 65021c5 🎉
@BridgeAR BridgeAR closed this Apr 28, 2018
MylesBorins pushed a commit that referenced this pull request May 4, 2018
@danbev @MylesBorins
stream: only check options once in Duplex ctor
fd912a3 
This commit updates the Duplex constructor adding an if statement checking if options is undefined, and removes the check from the following three if statements. PR-URL: #20353 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorins MylesBorins mentioned this pull request May 8, 2018
Merged
@danbev danbev deleted the _stream_duplex_constructor_options_check branch August 20, 2019 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. stream Issues and PRs related to the stream subsystem.

6 participants

@danbev @BridgeAR @jasnell @addaleax @lpinca @nodejs-github-bot