test: force context allocation in test module #18312
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
V8's behavior changed in c3bd741efd. Top-level variables in a module are no longer context-allocated by default.
Member Author
Member Author
| Adding reviewers of the PR that added the test in the first place. |
cjihrig reviewed Jan 24, 2018
| process.exit(55); | ||
| process.exit(55); | ||
| | ||
| (function force_context_allocation() { return t + k; }) |
Contributor
There was a problem hiding this comment.
Can you add a comment explaining why this is necessary. I worry that with the rate of code changes, the git commit message may get lost.
Member Author
| Added a comment as @cjihrig suggested. New CI job: https://ci.nodejs.org/job/node-test-pull-request/12726/ |
cjihrig approved these changes Jan 25, 2018
jasnell approved these changes Jan 26, 2018
Member Author
| Landed in fa33f02. |
hashseed added a commit that referenced this pull request Jan 26, 2018
V8's behavior changed in c3bd741efd. Top-level variables in a module are no longer context-allocated by default. PR-URL: #18312 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 20, 2018
V8's behavior changed in c3bd741efd. Top-level variables in a module are no longer context-allocated by default. PR-URL: #18312 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
V8's behavior changed in c3bd741efd. Top-level variables in a module are no longer context-allocated by default. PR-URL: #18312 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
V8's behavior changed in c3bd741efd. Top-level variables in a module are no longer context-allocated by default. PR-URL: #18312 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
Contributor
| setting don't land for 6 / 8 since the commit this is guarding against is not in the versions of V8 in either release stream |
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
V8's behavior changed in c3bd741efd. Top-level variables in a module are no longer context-allocated by default. PR-URL: nodejs#18312 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This is to anticipate
test/parallel/test-inspector-esm.jsfailing due to V8's behavior changing in c3bd741efd.Top-level variables in a module are then no longer context-allocated by default. That however is expected in the test. This change forces context allocation by closing over top-level variables.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test