doc: many grammar fixes to http2.md #17972
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
_shutdown_ is a noun, but the verb form is _shut down_. "There was a government shutdown during which the government shut down."
_instance_ was misspelled in the doc. The spelling has been corrected.
Use a dash consistently in _pseudo-header_ (which is also consistent with RFC 7540). Remove scare-quotes from the term.
Use _is_ rather than _are_ following "each of which". While "each of which are" might seem equally correct in passing, making the phrase slightly more explicit makes it clear that _is_ is the correct choice: "each one of which is".
"have need to" -> "need to"
"a block of...headers are received" -> "a block of...headers is received". The verb is for the block, not the headers.
"that the listener may used to specify" -> "that the listener may use to specify"
Fix comma splice. Also clarify if/then construction in previous clause.
"an ServerHttp2Stream" -> "a ServerHttp2Stream"
"maxmimum" -> "maximum"
"applications that supports" -> "applications that support"
Fix comma splice. Also "many modules uses" -> "many modules use".
"allows to support" -> "allows supporting"
"request status, headers and data" -> "request status, headers, and data"
"acknowledgement" -> "acknowledgment"
nodejs-github-bot added doc 
starkwang approved these changes Jan 4, 2018
maclover7 approved these changes Jan 4, 2018
Contributor
evanlucas approved these changes Jan 4, 2018
jasnell approved these changes Jan 4, 2018
lpinca approved these changes Jan 4, 2018
cjihrig approved these changes Jan 4, 2018
BridgeAR approved these changes Jan 4, 2018
BridgeAR added fast-track 
tniessen approved these changes Jan 5, 2018
jasnell pushed a commit that referenced this pull request Jan 5, 2018
PR-URL: #17972 Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Member
| Landed in 33123b9 |
MylesBorins pushed a commit to jasnell/node that referenced this pull request Jan 9, 2018
PR-URL: nodejs#17972 Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
MylesBorins pushed a commit that referenced this pull request Jan 9, 2018
Backport-PR-URL: #18050 PR-URL: #17972 Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Merged
MylesBorins pushed a commit that referenced this pull request Jan 10, 2018
Backport-PR-URL: #18050 PR-URL: #17972 Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
TimothyGu removed the author ready 
Contributor
| this doesn't land cleanly on v8.x, please feel free to manually backport |
kjin pushed a commit to kjin/node that referenced this pull request May 1, 2018
Backport-PR-URL: nodejs#18050 PR-URL: nodejs#17972 Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
MylesBorins pushed a commit that referenced this pull request May 2, 2018
Backport-PR-URL: #18050 Backport-PR-URL: #20456 PR-URL: #17972 Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
doc