test: add test of transform #17303
Closed
test: add test of transform #17303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Add a test case of Transform constructor.
hiroppy added the code-and-learn 
ronkorving approved these changes Nov 26, 2017
yosuke-furukawa approved these changes Nov 26, 2017
joyeecheung added the fast-track 
Member
lpinca approved these changes Nov 26, 2017
targos pushed a commit that referenced this pull request Nov 26, 2017
Add a test case of Transform constructor without new. PR-URL: #17303 Reviewed-By: Ron Korving <ron@ronkorving.nl> Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Member
| Landed in 9de15de Thank you for the contribution! |
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
Add a test case of Transform constructor without new. PR-URL: #17303 Reviewed-By: Ron Korving <ron@ronkorving.nl> Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
Add a test case of Transform constructor without new. PR-URL: #17303 Reviewed-By: Ron Korving <ron@ronkorving.nl> Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Merged
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
Add a test case of Transform constructor without new. PR-URL: #17303 Reviewed-By: Ron Korving <ron@ronkorving.nl> Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
Add a test case of Transform constructor without new. PR-URL: #17303 Reviewed-By: Ron Korving <ron@ronkorving.nl> Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Closed
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
Add a test case of Transform constructor without new. PR-URL: #17303 Reviewed-By: Ron Korving <ron@ronkorving.nl> Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This is part of Nodefest's Code and Learn nodejs/code-and-learn#72
I added a test case of Transform constructor. The constructor can work without
newoperator, but the behavior doesn't seem covered in current test cases according to the latest coverage report ( https://coverage.nodejs.org/coverage-3a4fe7791e1c2a1b/root/_stream_transform.js.html ).Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test