v8.9.2 proposal #17204
Merged
v8.9.2 proposal #17204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
If the console destination is a unix pipe (net.Socket), write() is async. If the destination is broken, we are adding an 'error' event listener to avoid a process crash. This PR makes sure that we are adding that listener only once. Fixes: #16767 PR-URL: #16770 Fixes: #16767 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
PR-URL: #16356 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Fixes: #16519 PR-URL: #16548 Backport-PR-URL: #16609 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
When `throw undefined` or `throw null` is executed, the REPL crashes. This change does a check for `null|undefined` before accessing an error's properties to prevent crashing. Fixes: #16545 Fixes: #16607 PR-URL: #16574 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Lance Ball <lball@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
PR-URL: #15895 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #16606 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: XadillaX <admin@xcoder.in> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This commit adds a missing comma in the sources list. This effects at least window which produces the following warning where trace_event.h and src/util.h are concatenated: Warning: Missing input files: src\tracing\trace_event.hsrc\util.h PR-URL: #16613 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Add test for ModuleMap set with ModuleJob but bad url. PR-URL: #16045 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
PR-URL: #16599 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Using Get() without the context argument will soon be deprecated. This also passed context to Int32Value() operations as well. PR-URL: #16641 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
doc: Add windowsVerbatimArguments docs for child_process spawn, spawnSync, execFile, and fork PR-URL: #16299 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1. `process.memoryUsage()` returns an object with 4 keys: `rss, heapTotal, headUsed, external`. There were brief explanations for the rest except `rss`. This commit adds this on the docs. 2. A little more clarity on `rss` to help people disambiguate it from the virtual memory size. PR-URL: #16566 Refs: #16566 (comment) Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Included reference to 'constant time' in crypto.timingSafeEqual description. The Node website would score higher on a Google search and the API would be more discoverable if it used the words "constant time" in its description. PR-URL: #16604 Fixes: #16504 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Pause child on startup using inspect-brk=0 until the parent debugger is ready. PR-URL: #15774 Fixes: #14897 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
We don't need to print out the output if we've already installed it, at the same time we do want to see some output when we haven't installed. PR-URL: #16551 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
PR-URL: #16638 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Various improvements on readability, performance and conformity to the Node core coding style in the ESM loader C++ code: - `isolate` for the `Isolate*`, `context` for the `Local<Context>` - Less reliance on `auto` where it’s unnecessary/increases cognitive overhead - Shorter paths to failure via `.ToLocal()` & co - Do not keep pending exceptions around e.g. for failed `JSON` parsing - Use `Maybe` types to get explicit error status forwarding - Remove an unnecessary handle scope - Add `nullptr` checks for unwrapped host objects - Remove unused code - Use `CamelCase` for function names - Use `const Foo&` instead of copying values whenever possible - Pass along the `Environment*` explicitly PR-URL: #16536 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
PR-URL: #16702 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
PR-URL: #16592 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Add `Http2Seettings` utility class for handling settings logic and reducing code duplication. PR-URL: #16668 Reviewed-By: Sebastiaan Deckers <sebdeckers83@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
PR-URL: #16718 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #16475 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This also updates the license builder. PR-URL: #16659 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Update test-repl-require-context to use fixtures module. PR-URL: #16799 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Use `common/fixtures` module instead in test-http2-client-upload.js PR-URL: #16800 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Currently the inspector module is always loaded and if it does not return anything the inspector console setup is skipped. This commit uses the process.config.variables.v8_enable_inspector variable to only load the inspector module if it is enabled. PR-URL: #15008 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #16933 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
In test-fs-realpath-on-substed-drive, require common/fixtures module and swapped the location of fixturesDir from common to fixtures module. PR-URL: #16813 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
`Sesssion` -> `Session` PR-URL: #16993 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #16978 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Update tools/doc/html.js and tools/eslint-rules/crypto-check.js to remove unused trailing function arguments in preparation for enabling a lint rule to enforce that practice. PR-URL: #16953 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Use linting to enforce that the final argument for a function must be used. PR-URL: #16953 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
* remove comment that isn't relevant/important * add comment that explains what the test does PR-URL: #16829 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #16842 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
PR-URL: #16936 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
nodejs-github-bot added lib / src 
Member Author
mscdex added meta 
12 tasks
Member
| careful with your release commit @gibfahn, it says 8.9.1 |
gibfahn force-pushed the v8.9.2-proposal branch from 82eb21e to e0498d1 Compare Notable Changes: - **console**: - avoid adding infinite error listeners (Matteo Collina) [#16770](https://github.com/nodejs/n de/pull/16770) - **http2**: - improve errors thrown in header validation (Joyee Cheung) [#16718](https://github.com/nodej s/node/pull/16718) PR-URL: #17204
gibfahn force-pushed the v8.9.2-proposal branch from e0498d1 to dcb2644 Compare Member Author
| Ready to go: CI: https://ci.nodejs.org/job/node-test-pull-request/11893/ |
PR-URL: #17204
gibfahn added a commit that referenced this pull request Dec 5, 2017
Notable Changes: - **console**: - avoid adding infinite error listeners (Matteo Collina) [#16770](https://github.com/nodejs/n de/pull/16770) - **http2**: - improve errors thrown in header validation (Joyee Cheung) [#16718](https://github.com/nodej s/node/pull/16718) PR-URL: #17204
gibfahn added a commit to gibfahn/nodejs.org that referenced this pull request Dec 5, 2017
gibfahn added a commit to nodejs/nodejs.org that referenced this pull request Dec 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
2017-12-05, Version 8.9.2 'Carbon' (LTS), @gibfahn
Notable Changes
de/pull/16770)
s/node/pull/16718)
Commits
1bf6250b99] - doc : mention constant-time in crypto doc (Mithun Sasidharan) #16604edb03cb65d] - Working on v8.9.2 (Gibson Fahnestock) #1678348813dee27] - 2017-11-07, Version 8.9.1 'Carbon' (LTS) (Gibson Fahnestock) #16783585f8698af] - build: include src\tracing when linting on win (Daniel Bevenius) #16720d9a18beaa6] - build: suppress lint-md output (Gibson Fahnestock) #165514e848d4afb] - build: add missing comma in sources list (Daniel Bevenius) #166139df1e8f10e] - console: avoid adding infinite error listeners (Matteo Collina) #167707ba037592d] - deps: cherry-pick cc55747 from V8 upstream (Franziska Hinkelmann) #16890c3c9a8d4bf] - doc: recommend node-core-utils for metadata (Rich Trott) #16978891ddad93c] - doc: fix typo in http2 doc (Gus Caplan) #16993ccd36467f8] - doc: reorganize COLLABORATOR_GUIDE.md (Rich Trott) #157108f0793ff93] - doc: clarify the prerequisites for building with VS2017 (Nikolai Vavilov) #169036e7a444a91] - doc: outline commit message for breaking changes (Maton Anthony) #168466eb550da34] - doc: remove duplicate 'the' from http2 API doc (Vipin Menon) #169240b8a400cad] - doc: correct the spelling of omitting in dgram.md (Vidya Subramanyam) #16910adb8f08c36] - doc: fix a typo in the documentation (Mamatha J V) #16909d721c0bb5e] - doc: improve documentation for the vm module (Franziska Hinkelmann) #16867360f40354e] - doc: fix typo in assert.md (Andres Kalle) #16866c4634bf506] - doc: update subprocess.killed (cjihrig) #16748eafc0a1314] - doc: fix a link in dgram.md (Vse Mozhet Byt) #16854fab55980be] - doc: add isTTY property documentation (SonaySevik) #16828f2a9c024ed] - doc: fix json generator warnings (Luigi Pinca) #167423319b2092f] - doc: update license to include node-inspect (Myles Borins) #166597618567b4f] - doc: add docs for Zlib#close() (Luigi Pinca) #165922cc05e0657] - doc: add nodejs/gyp team for GYP related issues (Gibson Fahnestock) #16638542f3b9cc0] - doc: add details about rss on process.memoryUsage (Anthony Nandaa) #1656613866b8b1b] - doc: add windowsVerbatimArguments docs (Andrew Stucki) #16299d2e4a87321] - doc: howto decode buffers extending from Writable (dicearr) #16403a2fd9a3cf2] - doc: add *-inl.h include rule to C++ style guide (Joyee Cheung) #165489b8e2a68d8] - http: use arrow fns for lexicalthisin Agent (Bryan English) #1647529efb02f12] - http2: multiple smaller code cleanups (James M Snell) #16764658301664f] - http2: improve errors thrown in header validation (Joyee Cheung) #167188cf8a327c8] - http2: refactor settings handling (James M Snell) #166684faf2ec783] - lib: replace string concatenation with template (Suryanarayana Murthy N) #1693314f8cee401] - lib: guard inspector console using process var (Daniel Bevenius) #150082ad051d62c] - lib: change concatenated string to template (Pawan Jangid) #1693028f036045b] - lib: change concatenated string to template (Nayana Das K) #16925134c2f31f2] - lib: replace string concatenation with template (subrahmanya chari p) #16917dc14c25ee9] - loader: test search module (Cyril Lakech) #16795d27ec13cd3] - repl: avoid crashing from null and undefined errors (cPhost) #1657440880897fe] - src: use unrefed async for GC tracking (Anna Henningsen) #16758f7411b5df7] - src: make StreamBase prototype accessors robust (Joyee Cheung) #168608d31294b3b] - src: CHECK() for argument overflow in Spawn() (cjihrig) #1676157b377ef93] - src: improve module loader readability (Anna Henningsen) #1653682076ed91f] - src: pass context to Get() operations for cares_wrap (Evan Lucas) #1664179e1d7719d] - src: remove unused includes in string_bytes.h (Daniel Bevenius) #16606cecd1e3def] - src: fix etw provider include on Windows (Joyee Cheung) #16639255fffbbc8] - src: do not include x.h if x-inl.h is included (Joyee Cheung) #16548efdd7c8cae] - test: reuse existing PassThrough implementation (Tobias Nießen) #16936375bec00a4] - test: use fixtures module for path resolve (sercan yersen) #168426ab706d7f0] - test: refactor comments in test-child-process-spawnsync-maxbuf (ChrBergert) #16829315fba8bfd] - test: used fixturesDir from fixtures modules (Klemen Kogovsek) #168135c8fb6a976] - test: refactor fs.write() test (Patrick Heneise) #168274f587e5a30] - test: add a test description (Grant Gasparyan) #16833af8b17a314] - test: use common/fixtures module in hash-seed test (Javier Blanco) #168233a3792b0a0] - test: improve template value for test message (Stephan Smith) #16826c3e6491a51] - test: unmark flaky test (Anna Henningsen) #16758bf9eb04abe] - test: change concatenated string to template (Deepthi Sebastian) #169297168a7e044] - test: change concatenated string to template (Anawesha Khuntia) #16912febd1bf519] - test: change string concatenation to template (Suryanarayana Murthy N) #169197164d9a6b8] - test: use template string for concatenation (Vipin Menon) #16918ae7106cc75] - test: replace string concatenation with template (Kabir Islam) #1691681a6c4f785] - test: enable mustCall() during child exit (Vipin Menon) #1691541f905bb00] - test: replace string concatenation with template (Sabari Lakshmi Krishnamoorthy) #16914be920aa372] - test: replace string concatenation with template (Tanvi Kini) #1691326d529e60f] - test: cover vm.runInNewContext() (cjihrig) #169066c57399c6b] - test: improve assertion messages (Neil Vass) #168851522562ffd] - test: pass process.env to child processes (Rod Vagg) #164050bc16cd9b6] - test: improve assert messages in stream test (Katie Stockton Roberts) #168847c9aee3348] - test: improve assertion in test-require-dot (Adam Wegrzynek) #168051b1bd261dc] - test: add values to error message (Adam Jeffery) #16831e66a7ae6e3] - test: replace common.fixtiresDir with fixtures.readKey() (woj) #16817c1309d6b80] - test: use tmpDir in test-fs-utimes (Rich Trott) #167742f1f7e1de0] - test: remove message argument in cluster setup test (mbornath) #16838d64fe485c5] - test: check session timeout in http2 (Anatoli Papirovski) #167544fcb03c0ae] - test: move test-http-keepalive-maxsockets to sequential (Rich Trott) #1677771c11d67f4] - test: improve assert messages in test-global (Mark McNelis) #16843ca278802ff] - test: use default assertion message (jonask) #16819ec4c3f5777] - test: improve message in test-fs-readfile-pipe-large (fjau) #16840562d8fca15] - test: remove custom message from assertion (Nicolas Morel) #168240ebded4376] - test: show incorrect value on test failure (Sean Karson) #168182bbc76eb1f] - test: include file mode in assert message (Sascha Tandel) #1681533f2fff52b] - test: refactor tls test to use fixtres.readSync (Brian O'Connell) #16816b307582d10] - test: use fixtures module in test-repl (Maring, Damian Lion) #168095719beaf83] - test: update test to use fixtures.readKey (Dara Hayes) #16811b166b6b1b3] - test: fix typos in read-buffer tests (Jimi van der Woning) #16834c4176eb722] - test: replace fixturesDir with usage of fixtures module (Octavian Ionescu) #16810af13678889] - test: clarified assert message for test-require-json.js (Matthias Reis) #168070fa659cdcd] - test: replace common.fixturesDir with fixtures module (Dumitru Glavan) #168031e6845d024] - test: replace common.fixturesDir with fixtures.readSync() (Adri Van Houdt) #168027b1491711d] - test: replacecommon.fixturesDirusage (Sascha Tandel) #16800480f14a55e] - test: update test to use fixtures (Adam Wegrzynek) #16799c52ac92661] - test: fix malformed parallel.status line (Rich Trott) #16702a41cc020fd] - test: fix flaky test-http2-server-rst-stream.js (Anatoli Papirovski) #166901e8a421159] - test: pause child until parent is ready (jBarz) #15774b3032d29c9] - test: increase coverage for ModuleMap (Rob Paton) #160452f66faf6cf] - test: use fixtures module in test-https-pfx (Ken Takagi) #15895981a1ef0c2] - test: use ES6 classes instead of util.inherits (Tobias Nießen) #1693847b1c3b43c] - test: add test for WrapStream readStop (Ashish Kaila) #1635672c34cf706] - test,net: remove scatological terminology (Rich Trott) #165992b903bff05] - tools: enforce no unused trailing arguments tools directory (Rich Trott) #1695357937e5746] - tools: remove unused trailing function arguments (Rich Trott) #1695385fd7bb8f7] - tools: fix inspector-check reporting (Daniel Bevenius) #169028538354139] - tools: add direct anchors for error codes (Joyee Cheung) #1677979006dab87] - tools: don't lint files that have not changed (Joyee Cheung) #16581cb08f5d6fe] - tools: remove unneeded parentheses in doc/html.js (Vse Mozhet Byt) #1684560c918ac7a] - tools: replace string concatenation with template literals (Kevin Yu) #16804aaf7e83d62] - tools: replace string concatenation with template literals (Giovanni Lela) #1680640fa970914] - tools: replace string concetation with templates (Patrick Heneise) #168010d4f62c85f] - tools,build: allow build withoutremark-cli(Refael Ackermann) #16893