test: removed literal from assert #16805
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
cjihrig approved these changes Nov 6, 2017
3 tasks
apapirovski added the code-and-learn 
Contributor
| I'm not sure that removing this allows for a more helpful error message. |
Member
@mscdex How about we restore the error message but also include @awegrzyn Can you change it to something like this?: assert.strictEqual( c.value, 42, `require(".") should honor NODE_PATH; expected 42, found ${c.value}` ); |
test/parallel/test-require-dot.js Outdated
| const c = require('.'); | ||
| | ||
| assert.strictEqual(c.value, 42, 'require(".") should honor NODE_PATH'); | ||
| assert.strictEqual(c.value, 42, `require(".") should honor NODE_PATH; expected 42, found ${c.value}`); |
Member
There was a problem hiding this comment.
this line will be well beyond 80 chars. Can you please format it ? hint: follow @Trott 's suggestion
gireeshpunathil approved these changes Nov 7, 2017
jasnell approved these changes Nov 8, 2017
Trott approved these changes Nov 8, 2017
Member
Trott pushed a commit to Trott/io.js that referenced this pull request Nov 8, 2017
Include the value that differed from the expected value in an assertion message in test-require-dot. PR-URL: nodejs#16805 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Member
| Landed in d520059. |
evanlucas pushed a commit that referenced this pull request Nov 13, 2017
Include the value that differed from the expected value in an assertion message in test-require-dot. PR-URL: #16805 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
MylesBorins pushed a commit that referenced this pull request Nov 17, 2017
Include the value that differed from the expected value in an assertion message in test-require-dot. PR-URL: #16805 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 17, 2017
Include the value that differed from the expected value in an assertion message in test-require-dot. PR-URL: #16805 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
Merged
MylesBorins pushed a commit that referenced this pull request Nov 21, 2017
Include the value that differed from the expected value in an assertion message in test-require-dot. PR-URL: #16805 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 28, 2017
Include the value that differed from the expected value in an assertion message in test-require-dot. PR-URL: #16805 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Removed literal from assert to display default message.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test