tools: replace string concatenation with template literals #16804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added doc 
gireeshpunathil added the code-and-learn 
tools/doc/preprocess.js Outdated
apapirovski reviewed Nov 6, 2017
tools/doc/preprocess.js Outdated
Contributor
There was a problem hiding this comment.
Multi-line string concatenation is actually ok (the way it was before), but it would be nice if the 2nd line became this instead:
`${inc}\n<!-- [end-include:${fname}] -->\n`That way we don't have to lose indentation level.
vsemozhetbyt approved these changes Nov 6, 2017
Contributor
Trott approved these changes Nov 6, 2017
apapirovski approved these changes Nov 6, 2017
Trott pushed a commit to Trott/io.js that referenced this pull request Nov 6, 2017
Replace string concatenation with template literals in tools/doc/preprocess.js. PR-URL: nodejs#16804 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Member
| Landed in 13e983b |
Member
| Thanks for the contribution! 🎉 |
cjihrig pushed a commit to cjihrig/node that referenced this pull request Nov 7, 2017
Replace string concatenation with template literals in tools/doc/preprocess.js. PR-URL: nodejs#16804 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Merged
MylesBorins pushed a commit that referenced this pull request Nov 16, 2017
Replace string concatenation with template literals in tools/doc/preprocess.js. PR-URL: #16804 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
MylesBorins pushed a commit that referenced this pull request Nov 16, 2017
Replace string concatenation with template literals in tools/doc/preprocess.js. PR-URL: #16804 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Merged
Merged
MylesBorins pushed a commit that referenced this pull request Nov 21, 2017
Replace string concatenation with template literals in tools/doc/preprocess.js. PR-URL: #16804 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
MylesBorins pushed a commit that referenced this pull request Nov 28, 2017
Replace string concatenation with template literals in tools/doc/preprocess.js. PR-URL: #16804 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Replace string concatenation in tools/doc/preprocess.js with template literals.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)