v8.9.0 proposal #16630
Merged
v8.9.0 proposal #16630
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Currently building with debug enabled produces the following errors: In file included from ../src/node_http2.h:6: ../src/node_http2_core-inl.h:465:18: error: expected ';' after do/while statement CHECK_GT(id, 0) ^ ; ../src/node_http2_core-inl.h:469:18: error: use of undeclared identifier 'spec' OnPriority(id, spec.stream_id, spec.weight, spec.exclusive); ^ ../src/node_http2_core-inl.h:469:34: error: use of undeclared identifier 'spec' OnPriority(id, spec.stream_id, spec.weight, spec.exclusive); ^ ../src/node_http2_core-inl.h:469:47: error: use of undeclared identifier 'spec' OnPriority(id, spec.stream_id, spec.weight, spec.exclusive); ^ This commit adds the missing semicolon to fix the above error. ../src/node_http2.cc:92:9: error: reference to non-static member function must be called; did you mean to call it with no arguments? CHECK(object->Has(context, env()->ongetpadding_string()).FromJust()); ^~~~~~ ../src/util.h:120:20: note: expanded from macro 'CHECK' if (UNLIKELY(!(expr))) { \ ^~~~ ../src/util.h:107:44: note: expanded from macro 'UNLIKELY' For this issue I was not sure what the correct check would be so I've just commented it out and will update after feedback. PR-URL: #16432 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> 
Add tests ported from Web Platform Tests. Graduate TextEncoder / TextDecoder from experimental PR-URL: #15743 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com>
PR-URL: #16369 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
When compiling with --debug-http2 flag, compiler complains about passing wrong type of argument to DEBUG_HTTP2. Fix by using static_cast to uint32_t. PR-URL: #16373 Reviewed-By: James M Snell <jasnell@gmail.com>
Setting /MP globally causes it to appear twice in the command line due to a GYP bug, which causes the project to be rebuilt unconditionally due to an msbuild bug. PR-URL: #16415 Fixes: #16367 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Refael Ackermann <refack@gmail.com>
`deps/uv/src/ares` hasn't existed since libuv/libuv@41b1265 (mid 2012). PR-URL: #16384 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This commit removes the unused handle_wrap.h and instead adds uv.h which is used. PR-URL: #16379 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
This commit removes an "empty" comment in node_http2.h that I don't think was intentional and as far as I can tell not a doxygen comment or anything like that. This was not picked up by the cpp linter so a suggestion has also been added to the CheckComment function to detect these in the future. PR-URL: #16400 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This commit allows custom lookup paths to be passed to require.resolve(). It also adds require.resolve.paths() which retrieves the default resolution paths. Fixes: #5963 Fixes: #16389 PR-URL: #16397 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Wyatt Preul <wpreul@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Because of the specific serialization and processing requirements of HTTP/2, sockets should not be directly manipulated. This forbids any interactions with destroy, emit, end, pause, read, resume and write methods of the socket. It also redirects setTimeout to session instead of socket. PR-URL: #16330 Fixes: #16252 Refs: #16211 Reviewed-By: James M Snell <jasnell@gmail.com>
Provide section headings for server-side and client side examples. Add error handling and TLS to server-side example, following example of `https`. Add error handling, TLS, more efficient Buffer usage, and header printing to client example. PR-URL: #16366 Fixes: #16345 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
PR-URL: #12756 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
PR-URL: #12756 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
PR-URL: #12756 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
PR-URL: #12756 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
PR-URL: #12756 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
PR-URL: #12756 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
The npm install rules had a hidden dependency on the `node` binary install rule creating the `$PREFIX/bin` directory. Because with `./configure --shared` no binary is created, the rule subsequently failed. Fix that by creating the directory before creating the symlinks to the npm and npx scripts. (Whether it makes sense to install npm without a `node` binary is a separate question. This commit is not taking positions. :-)) Regression introduced in commit ed8c89a ("build: fix shared installing target") which, as the commit log indicates, was itself a bug fix for the `./configure --shared` install. PR-URL: #16438 Fixes: #16437 Ref: #15148 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> 
The inspector_agent depends on the context still being accessible during the destructor execution. PR-URL: #16472 Fixes: #15558 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Currently when running the test without an internet connection there are two JavaScript test failures and one cctest. The cctest only fails on Mac as far as I know. (I've only tested using Mac and Linux thus far). This commit moves the two JavaScript tests to test/internet. The details for test_inspector_socket_server.cc: [ RUN ] InspectorSocketServerTest.FailsToBindToNodejsHost make[1]: *** [cctest] Segmentation fault: 11 make: *** [test] Error 2 lldb output: [ RUN ] InspectorSocketServerTest.FailsToBindToNodejsHost Process 63058 stopped * thread #1: tid = 0x7b175, 0x00007fff96d04384 * libsystem_info.dylib`_gai_simple + 87, queue = * 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, * address=0x0) frame #0: 0x00007fff96d04384 libsystem_info.dylib`_gai_simple + 87 libsystem_info.dylib`_gai_simple: -> 0x7fff96d04384 <+87>: movw (%rdx), %ax 0x7fff96d04387 <+90>: movw %ax, -0x2a(%rbp) 0x7fff96d0438b <+94>: movq %r13, -0x38(%rbp) 0x7fff96d0438f <+98>: movq 0x18(%rbp), %rcx (lldb) bt * thread #1: tid = 0x7b175, 0x00007fff96d04384 * libsystem_info.dylib`_gai_simple + 87, queue = * 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, * address=0x0) * frame #0: 0x00007fff96d04384 libsystem_info.dylib`_gai_simple + 87 frame #1: 0x00007fff96cfe98b libsystem_info.dylib`search_addrinfo + 179 frame #2: 0x00007fff96cfafef libsystem_info.dylib`si_addrinfo + 2255 frame #3: 0x00007fff96cfa67b libsystem_info.dylib`getaddrinfo + 179 frame #4: 0x00000001017d8888 cctest`uv__getaddrinfo_work(w=0x00007fff5fbfe210) + 72 at getaddrinfo.c:102 frame #5: 0x00000001017d880e cctest`uv_getaddrinfo(loop=0x000000010287cb80, req=0x00007fff5fbfe1c8, cb=0x0000000000000000, hostname="nodejs.org", service="0", hints=0x00007fff5fbfe268) + 734 at getaddrinfo.c:192 frame #6: 0x000000010171f781 cctest`node::inspector::InspectorSocketServer::Start(this=0x00007fff5fbfe658) + 801 at inspector_socket_server.cc:398 frame #7: 0x00000001016ed590 cctest`InspectorSocketServerTest_FailsToBindToNodejsHost_Test::TestBody(this=0x0000000105001fd0) + 288 at test_inspector_socket_server.cc:593 I'm not sure about the exact cause for this but when using a standalone c program to simulate this it seems like when the ai_flags `AI_NUMERICSERV` is set, which is done in inspector_socket_server.cc line 394, the servname (the port in the FailsToBindToNodejsHost test) is expected to be a numeric port string to avoid looking it up in /etc/services. When the port is 0 as is it was before this commit the segment fault occurs but not if it is non-zero. PR-URL: #16255 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
This is for issue 16452. When 'set-cookie' header is set with an array that has only one string value, it's split into its individual characters. Fix by resetting `isArray` to false when the value is converted from an array to a string. Fixes: #16452 PR-URL: #16458 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Libuv 1.15.0 improved console resize detection on Windows. This note is no longer needed. PR-URL: #16320 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Make node_crypto_clienthello-inl.h self-contained. PR-URL: #16518 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #16460 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Makes eslint exclude directories without enumerating their content PR-URL: #16372 Refs: #16010 Refs: #16278 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
`.tmp` prefix allows easier exclusion PR-URL: #16372 Refs: #16010 Refs: #16278 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
also undocument the `vcbuild.bat` command since it's broken and seems to only be relevant to release builds PR-URL: #16372 Refs: #16010 Refs: #16278 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Rather than using `http`, use `_http_client`, etc. directly. Also moving all the exports to the bottom, in line with most of the rest of the codebase. PR-URL: #16395 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #16142 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Contributor
| @richardlau I've opened #16637 to update the license file. edit: @gibfahn please do not release this without including that patch |
The LICENSE file was not originally included when remark-cli was vendored. This Commit adds the LICENSE file back to tools/remark-cli and updates the top level license in the project PR-URL: #16637 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This LTS release comes with 87 commits. This includes 30 that are updates to lib/ or src/, 20 that are test related, 13 that are doc related, 19 which are build / tools related, and 4 commits which are updates to dependencies. Notable Changes: * doc: - add Gibson Fahnestock to Release team (Gibson Fahnestock) #16620 * deps: - update npm to 5.5.1 (Myles Borins) #16509 * http2: - The exposed http2 socket is no longer manipulatable (Anatoli Papirovski) #16330 * module: - support custom paths to require.resolve() (cjihrig) #16397 * util: - util.TextEncoder and util.TextDecoder are no longer experimental. There will no longer be a warning when they are used (James M Snell) #15743 PR-URL: #16630
gibfahn force-pushed the v8.9.0-proposal branch from f5e614a to f76ce0a Compare 
Member Author
| Added remark-cli License update CI 4: https://ci.nodejs.org/job/node-test-commit/13633/ |
jasnell approved these changes Oct 31, 2017
Member
jasnell left a comment
jasnell left a comment There was a problem hiding this comment.
LGTM. This needs to go out first so that I can update the changelog in 9.0.0. This includes many of the minors and patches that are listed in the 9.0.0 changelog currently.
Member Author
| Release build: https://ci-release.nodejs.org/job/iojs+release/2187/ |
cjihrig approved these changes Oct 31, 2017
Member
| @gibfahn ... when are you planning to promote the 8.9.0 release? |
PR-URL: #16630
gibfahn added a commit that referenced this pull request Oct 31, 2017
This LTS release comes with 87 commits. This includes 30 that are updates to lib/ or src/, 20 that are test related, 13 that are doc related, 19 which are build / tools related, and 4 commits which are updates to dependencies. Notable Changes: * doc: - add Gibson Fahnestock to Release team (Gibson Fahnestock) #16620 * deps: - update npm to 5.5.1 (Myles Borins) #16509 * http2: - The exposed http2 socket is no longer manipulatable (Anatoli Papirovski) #16330 * module: - support custom paths to require.resolve() (cjihrig) #16397 * util: - util.TextEncoder and util.TextDecoder are no longer experimental. There will no longer be a warning when they are used (James M Snell) #15743 PR-URL: #16630
jasnell pushed a commit that referenced this pull request Oct 31, 2017
This LTS release comes with 87 commits. This includes 30 that are updates to lib/ or src/, 20 that are test related, 13 that are doc related, 19 which are build / tools related, and 4 commits which are updates to dependencies. Notable Changes: * doc: - add Gibson Fahnestock to Release team (Gibson Fahnestock) #16620 * deps: - update npm to 5.5.1 (Myles Borins) #16509 * http2: - The exposed http2 socket is no longer manipulatable (Anatoli Papirovski) #16330 * module: - support custom paths to require.resolve() (cjihrig) #16397 * util: - util.TextEncoder and util.TextDecoder are no longer experimental. There will no longer be a warning when they are used (James M Snell) #15743 PR-URL: #16630
Member Author
Done |
MylesBorins pushed a commit to nodejs/Release that referenced this pull request Oct 31, 2017
Also changes `Active` and `Maintenance` to `Active LTS` and `Maintenance LTS`. Fixes: #257 Refs: nodejs/node#16630
gibfahn added a commit to gibfahn/nodejs.org that referenced this pull request Oct 31, 2017
gibfahn added a commit to nodejs/nodejs.org that referenced this pull request Oct 31, 2017
Member
| @gibfahn armv6l binaries didn't complete, I've started them again and will let you know when I can get them out properly, so much Pi trouble at the moment. |
Member
| @gibfahn armv6l binaries are in staging, run |
Qard pushed a commit to ayojs/ayo that referenced this pull request Nov 2, 2017
This LTS release comes with 87 commits. This includes 30 that are updates to lib/ or src/, 20 that are test related, 13 that are doc related, 19 which are build / tools related, and 4 commits which are updates to dependencies. Notable Changes: * doc: - add Gibson Fahnestock to Release team (Gibson Fahnestock) nodejs/node#16620 * deps: - update npm to 5.5.1 (Myles Borins) nodejs/node#16509 * http2: - The exposed http2 socket is no longer manipulatable (Anatoli Papirovski) nodejs/node#16330 * module: - support custom paths to require.resolve() (cjihrig) nodejs/node#16397 * util: - util.TextEncoder and util.TextDecoder are no longer experimental. There will no longer be a warning when they are used (James M Snell) nodejs/node#15743 PR-URL: nodejs/node#16630
Qard pushed a commit to ayojs/ayo that referenced this pull request Nov 2, 2017
This LTS release comes with 87 commits. This includes 30 that are updates to lib/ or src/, 20 that are test related, 13 that are doc related, 19 which are build / tools related, and 4 commits which are updates to dependencies. Notable Changes: * doc: - add Gibson Fahnestock to Release team (Gibson Fahnestock) nodejs/node#16620 * deps: - update npm to 5.5.1 (Myles Borins) nodejs/node#16509 * http2: - The exposed http2 socket is no longer manipulatable (Anatoli Papirovski) nodejs/node#16330 * module: - support custom paths to require.resolve() (cjihrig) nodejs/node#16397 * util: - util.TextEncoder and util.TextDecoder are no longer experimental. There will no longer be a warning when they are used (James M Snell) nodejs/node#15743 PR-URL: nodejs/node#16630
Member Author
Done in nodejs/nodejs.org#1447 |
addaleax pushed a commit to ayojs/ayo that referenced this pull request Dec 7, 2017
This LTS release comes with 87 commits. This includes 30 that are updates to lib/ or src/, 20 that are test related, 13 that are doc related, 19 which are build / tools related, and 4 commits which are updates to dependencies. Notable Changes: * doc: - add Gibson Fahnestock to Release team (Gibson Fahnestock) nodejs/node#16620 * deps: - update npm to 5.5.1 (Myles Borins) nodejs/node#16509 * http2: - The exposed http2 socket is no longer manipulatable (Anatoli Papirovski) nodejs/node#16330 * module: - support custom paths to require.resolve() (cjihrig) nodejs/node#16397 * util: - util.TextEncoder and util.TextDecoder are no longer experimental. There will no longer be a warning when they are used (James M Snell) nodejs/node#15743 PR-URL: nodejs/node#16630
ChALkeR pushed a commit to ChALkeR/LTS that referenced this pull request Jun 30, 2018
Also changes `Active` and `Maintenance` to `Active LTS` and `Maintenance LTS`. Fixes: nodejs#257 Refs: nodejs/node#16630
Soufiane88216 added a commit to Soufiane88216/Release that referenced this pull request Jan 30, 2025
Also changes `Active` and `Maintenance` to `Active LTS` and `Maintenance LTS`. Fixes: nodejs/Release#257 Refs: nodejs/node#16630
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
2017-10-31, Version 8.9.0 'Carbon' (LTS), @gibfahn
This release marks the transition of Node.js v8 into Long Term Support (LTS) with the codename 'Carbon'. The v8 release line now moves in to "Active LTS" and will remain so until April 2019. After that time it will move in to "Maintenance" until end of life in December 2019.
Notable Changes
Commits
d576e17691] - build: make test-doc and lint addon docs (Joyee Cheung) #1637763e33ac327] - build: make doc target quiet (Daniel Bevenius) #16516528edb2ea8] - build: ignore empty folders in test-addons-napi (Anna Henningsen) #16380c8a3b2d171] - build: run linter before running tests (Joyee Cheung) #16284a763fcd7a7] - build: improvemake clean(Refael Ackermann) #163720a1f7fefc6] - build: skip bin override on windows (Hitesh Kanwathirtha) #164603b64fa451e] - build: fix npm install with --shared (Ben Noordhuis) #164389185cfef9c] - build: add lint-md-build (Daijiro Wachi) #1275622ec800b20] - build: do not include deleted directory (Jon Moss) #16384b5c6d596ca] - build,win: set /MP separately in Debug and Release (Nikolai Vavilov) #164159bea207e83] - child_process: fix memory leak in .fork() (Ben Noordhuis) #15679bf2564df0d] - deps: V8: backport b1cd96e from upstream (Ali Ijaz Sheikh) #16308ad692074a4] - deps: cherry-pick e0d64dc from upstream V8 (Michaël Zasso) #164907bdb8db440] - deps: cherry-pick 676c413 from upstream V8 (Michaël Zasso) #164905787f5331f] - deps: cherry-pick 2c75616 from upstream V8 (Michaël Zasso) #164900d7e4d2bdc] - deps: update npm to 5.5.1 (Myles Borins) #165094d9c1bedbd] - doc: add Gibson Fahnestock to Release team (Gibson Fahnestock) #16620d6619b9ad4] - doc: document missing error codes (George Bezerra) #15160fdc072bd9c] - doc: fix inconsistent server.listen documentation (Martin Michaelis) #16020a6b3cd8166] - doc: more accurate zlib windowBits information (Anna Henningsen) #16511e5c2059f88] - doc: make default values and periods consistent (Matej Krajčovič) #16563b93275e1a3] - doc: slightly relax 50 character rule (James M Snell) #165231b08ae853e] - doc: http2.connect accepts net & tls options (Anatoli Papirovski) #1657604602109e8] - doc: add note to releases.md (Jon Moss) #1650703b233ed40] - doc: fix CHANGELOG_V8 indentation (Jon Moss) #16507a7540d59e8] - doc: remove http2 pushStream weight option (Sebastiaan Deckers) #164514ba06d07cc] - doc: add dot in documentations (erwinwahyura) #1654283902e6e02] - doc: add multiple build guide to benchmarking doc (Peter Marton) #1614204fac61fdd] - doc: improve http2 documentation (Jacob Hoffman-Andrews) #16366fe5d4535c9] - doc, win: remove note about resize (Bartosz Sosnowski) #1632054ebf91394] - http2: make sessions garbage-collectible (Anna Henningsen) #16461bfc1ad07a3] - http2: remove unused assignment (Anna Henningsen) #1646156dd734a6a] - http2: track async state for sending (Anna Henningsen) #164615390d7e374] - http2: move uv_prepare handle toHttp2Session(Anna Henningsen) #1646195a61cbb1e] - http2: fix stream reading resumption (Anatoli Papirovski) #1658098b9705cb8] - http2: simplify mapToHeaders, stricter validation (Anatoli Papirovski) #16575e592c320ce] - http2: fix several timeout related issues (Anatoli Papirovski) #1652524fd8ff32a] - http2: adjust stream buffer size (Anatoli Papirovski) #164452c2b6586e7] - http2: fix mapToHeaders() with single string value (Jinwoo Lee) #16458e6e99eb447] - http2: do not allow socket manipulation (Anatoli Papirovski) #163303638694d8b] - http2: fix errors in debug statements (Anatoli Papirovski) #16373754df71a79] - https: refactor to use http internals (Bryan English) #163952ea25ad3e2] - inspector: track async stacks when necessary (Ali Ijaz Sheikh) #16308ab0d7a64aa] - lib: refactor wrap_js_stream for ES6/readability (Anna Henningsen) #1615887fd5b798f] - lib: move _stream_wrap into internals (Anna Henningsen) #1615896e82509b0] - lib: use destructuring for some constants (Weijia Wang) #160636be494251b] - lib: move duplicate spliceOne into internal/util (Weijia Wang) #162218c0c456c73] - lib: setup IPC channel before console (Nikolai Vavilov) #165623a230b42f3] - lib: internal/errors should not be executable (Jon Moss) #16369415fb56735] - module: fix extension lookups for top-level main (Guy Bedford) #16526e68307737c] - module: fix hook module CJS dependency loading (guybedford) #16381ac02a0be28] - (SEMVER-MINOR) module: support custom paths to require.resolve() (cjihrig) #16397e578268ef9] - src: addInternalCallbackScopeutil constructor (Anna Henningsen) #164616ac7eefe41] - src: move handle properties to prototype (Ben Noordhuis) #164823a54bb5c2c] - src: remove superfluous HandleScope (Ben Noordhuis) #1648277c02aab5b] - src: use uv_stream_t, not uv_stream_s (Ben Noordhuis) #16512a194d831fe] - src: use maybe versions of methods (Tom Boutell) #16005ec5168813b] - src: use V8 function to get Module Namespace (Bradley Farias) #162610a5a2c43b1] - src: fix vm module for strict mode (Franziska Hinkelmann) #16487ee40368c87] - src: make header file self-contained (Joyee Cheung) #16518465540cc98] - src: destroy inspector agent before context (Ali Ijaz Sheikh) #164729bca6200ad] - src: remove empty comment in node_http2.h (Daniel Bevenius) #16400f0576c5ee0] - src: remove unused include in tty_wrap.h (Daniel Bevenius) #16379f00ba6b142] - src: fix http2 debug build errors (Daniel Bevenius) #16432889f42a924] - test: remove empty comments in http2 tests (Gibson Fahnestock) #16631a62845565e] - test: add block scoping to test-assert-deep (Rich Trott) #165320510f42efc] - test: update test-timers-block-eventloop.js (zhangzifa) #16314bac2aff23d] - test: include actual value in assertion message (Matthew Cantelon) #15935d185bfdcef] - test: replace fixturesDir in test-tls-connect (Casie Lynch) #15849ce07cbeacb] - test: use fixtures module (Iryna Yaremtso) #159012e1b45db07] - test: add details in assertions in test-vm-context (Vladimir Ilic) #161164f47e2df44] - test: increase fs.exists coverage (Nigel Kibodeaux) #1596301058c412e] - test: use fixtures module in test-fs-realpath.js (Raphael Rheault) #15904fe9cca2e0f] - test: use fixtures module (Scott J Beck) #15843b4af92280b] - test: imporove assert messages (Hadis-Fard) #16021604ab12447] - test: show values instead of assertion message (Cheyenne Arrowsmith) #15979aea09da6f9] - test: include values in assertion messages (nhoel) #15996ea32d0ec4e] - test: use process.features.debug in common module (Rich Trott) #16537a0fcd4d219] - test: use common.buildType in repl-domain-abort (Rich Trott) #16538525700b3d5] - test: skip test-process-config if no config.gypi (Gibson Fahnestock) #16436aaacddbcbf] - test: use fixtures module in tls-handshake-error (Mark Walker) #15939977fe22290] - test: add failing vm tests to known_issues (Michaël Zasso) #1641002ac8bae91] - test: change tmp directories prefix (Refael Ackermann) #16372568d614dc3] - test: allow tests to pass without internet (Daniel Bevenius) #162553d8a7e97fe] - tools: modernize license2rtf (Tobias Nießen) #16220d5891b5330] - tools: replace loop with padStart (Tobias Nießen) #16220b1e2a38d90] - tools: fix cpplint.py when path contains non-ascii (sharkfisher) #16047e80d878b3f] - tools: no trailing slash in ignore patterns (Refael Ackermann) #1637231f54e5fb9] - tools: add make lint-md-clean (Daijiro Wachi) #12756ea415a663e] - tools: add lint-md command in Makefile (Daijiro Wachi) #127563522e765be] - tools: use remark-preset-lint-node in .remarkrc (Daijiro Wachi) #127568d62116cf0] - tools: introduce remark-preset-lint-node (Daijiro Wachi) #127563d499b3712] - tools: introduce remark-cli@3.0.1 (Daijiro Wachi) #1275655ba1d4115] - util: expand test coverage for util.deprecate (Ashish Kaila) #163058fd75fb9b5] - (SEMVER-MINOR) util: graduate TextEncoder/TextDecoder, tests (James M Snell) #15743